Not define __TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENT for Clang#2024
Open
fujunwei wants to merge 1 commit intouxlfoundation:masterfrom
Open
Not define __TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENT for Clang#2024fujunwei wants to merge 1 commit intouxlfoundation:masterfrom
fujunwei wants to merge 1 commit intouxlfoundation:masterfrom
Conversation
Contributor
|
@fujunwei, could you please rebase your branch from master to ensure all the checks pass? Thanks in advance! |
Contributor
|
I notice your change also fail on the copyright check. After some struggle I figured out that this check expect a line like "Copyright (c) 2026 UXL Foundation Contributors" in the headers where it claim there is missing copyright information. |
fujunwei
force-pushed
the
build_openvino_with_chromium
branch
from
4ada617 to
494ac34
Compare
Author
|
Rebased the latest code, PTAL. Thanks. |
Author
|
/cc @huningxin |
Author
|
@dnmokhov @petterreinholdtsen could you please take a look again, thanks. |
dnmokhov
reviewed
Apr 3, 2026
Comment on lines
267
to
+268
| __TBB_GLIBCXX_VERSION >= 90000 && __TBB_LANG >= 201703L) | ||
| #define __TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENT (_MSC_VER >= 1911) | ||
| #define __TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENT (_MSC_VER >= 1911 && !__clang__) |
Contributor
There was a problem hiding this comment.
This has an undesirable effect of disabling std::hardware_destructive_interference_size for ICX (which is Clang-based). Have you considered using something like __has_feature instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are trying to build OpenVINO with Chromiumt, but the
__TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENTis only defined for MSVC (_MSC_VER >= 1911), the Clang (used in Chromium builds) doesn't supportstd::hardware_destructive_interference_sizethat is not available in Clang's standard library, so adds&& !__clang__to the__TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENTmacro.