Skip to content

Account for cgroups constraints in the NUMA task arena conformance test #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaevil merged 3 commits into from
Mar 19, 2026
+3 −2
Merged

Account for cgroups constraints in the NUMA task arena conformance test #2014

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b96604
Check for cgroups constraints
dnmokhov Mar 17, 2026
3de4625
Apply suggestions from code review
dnmokhov Mar 18, 2026
819c3f1
Fix indentation
dnmokhov Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test/conformance/conformance_arena_constraints.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,12 @@ TEST_CASE("Test reserved slots argument in create_numa_task_arenas") {
// concurrnecy of the single NUMA - 1. This means that for task_arena with reserved_slots=0
// worker threads won't be able to fully saturate the arena.
// This flag is set to adjust test expectations accordingly.
bool workers_cannot_fully_occupy_arena = numa_nodes_info.size() == 1 && reserved_slots == 0;
bool cpu_constrained = false;
#if __TBB_USE_CGROUPS
int cgroup_num_cpus = 0;
cpu_constrained = utils::cgroup_info::is_cpu_constrained(cgroup_num_cpus);
#endif
bool workers_cannot_fully_occupy_arena = (numa_nodes_info.size() == 1 || cpu_constrained) && reserved_slots == 0;
for (auto& ta : numa_task_arenas) {
// For the case when task_arena is created with both max_concurrency and reserved_slots
// equal to 1 oneTBB creates a special additional worker to execute an "enqueue" task.
Expand Down
Loading