Conversation
aleksei-fedotov
requested review from
akukanov,
isaevil,
kboyarinov,
omalyshe and
vossmjp
|
|
||
| 2. /Library/ | ||
|
|
||
| This number reflects the version of the binary. It consists of three numbers: =major=, =minor=, |
There was a problem hiding this comment.
Shouldn't be mentioned that this is only for Linux and for Windows binaries are not versioned?
There was a problem hiding this comment.
Changed to library to avoid confusion with the naming of executable files.
| number of available cores. | ||
| - *Load imbalance*: Some cores may be idle while others are overloaded due to poor resource | ||
| distribution. | ||
| - *Performance degradation*: The overall application performance suffers despite individual |
There was a problem hiding this comment.
Isn't this mostly covered by the three previous points. The reason why the individual components perform well in isolation but not together is due to resource contention, oversubscription or load imbalance. So maybe you can remove this point.
There was a problem hiding this comment.
I think you are right. Removed.
| Since Thread Composability Manager provides a general interface to consult on CPU utilization and | ||
| allows any threading framework to get recommendations on the use of CPU resources, the proposal is | ||
| to make the TCM more available so that everyone interested can leverage its use and make their | ||
| parallel runtime composable with oneTBB and Intel's OpenMP now, and with more and more threading | ||
| runtimes in the future, allowing users to use those parallel runtimes in which they are fluent the | ||
| most and/or which fit computations the best. |
There was a problem hiding this comment.
I'd suggest also breaking it into two or more sentences since its rather long, which probably make its difficult to read.
| Since Thread Composability Manager provides a general interface to consult on CPU utilization and | |
| allows any threading framework to get recommendations on the use of CPU resources, the proposal is | |
| to make the TCM more available so that everyone interested can leverage its use and make their | |
| parallel runtime composable with oneTBB and Intel's OpenMP now, and with more and more threading | |
| runtimes in the future, allowing users to use those parallel runtimes in which they are fluent the | |
| most and/or which fit computations the best. | |
| Since Thread Composability Manager provides a general interface to consult on CPU utilization and | |
| allows any threading framework to get recommendations on the use of CPU resources, the proposal is | |
| to make the TCM more available so that everyone interested can use it. Integration with TCM will make a | |
| parallel runtime more composable with oneTBB and Intel's OpenMP now, and possibly more threading | |
| runtimes in the future. Users will then have more choice to use the parallel runtimes in which they are | |
| fluent and that best fit their computations, while still creating composable parallelism. |
akukanov
left a comment
akukanov
left a comment
There was a problem hiding this comment.
The proposal now looks good to go; the suggestions below are not critical.
| To avoid confusion about whether a particular patch, issue or any other repository activity is | ||
| related to oneTBB or TCM project, '[TCM]' prefix will be used to mark TCM activities. |
There was a problem hiding this comment.
Does it make sense to also add a special label for TCM related "records" in the repo? The prefix is still needed for commit messages, so I am not sure if adding a label will be useful or not so much.
akukanov
left a comment
akukanov
left a comment
There was a problem hiding this comment.
No more questions from me at this point.
isaevil
left a comment
isaevil
left a comment
There was a problem hiding this comment.
Since there are enough of approvals, let's fix the spelling and merge?
| 1. User does not specify anything explicit about build of TCM: | ||
| - TCM dependencies are met: TCM is built. | ||
| - TCM dependencies are not met: A message about not able to build TCM appears on the screen, | ||
| futher configuration and building of other targets continues. |
There was a problem hiding this comment.
| futher configuration and building of other targets continues. | |
| further configuration and building of other targets continues. |
aleksei-fedotov
dismissed stale reviews from dnmokhov, vossmjp, and akukanov
via
c7b2347
6 participants
Please read the RFC from this PR.