Merged
Conversation
akukanov
force-pushed
the
dev/ranges-replace-copy-akukanov
branch
from
926673f to
805aa7c
Compare
akukanov
requested review from
SergeyKopienko,
danhoeflinger and
dmitriy-sobolev
Comment on lines
+35
to
+38
| test_range_algo<0, int, data_in_out_lim>{big_sz}(dpl_ranges::replace_copy_if, replace_copy_if_checker, pred, -29); | ||
| test_range_algo<1, int, data_in_out_lim>{}(dpl_ranges::replace_copy_if, replace_copy_if_checker, pred1, -277, proj); | ||
| test_range_algo<2, P2, data_in_out_lim>{}(dpl_ranges::replace_copy_if, replace_copy_if_checker, pred2, -43, &P2::x); | ||
| test_range_algo<3, P2, data_in_out_lim>{}(dpl_ranges::replace_copy_if, replace_copy_if_checker, pred3, -817, &P2::proj); |
Contributor
There was a problem hiding this comment.
A case with different types of R and OutR is not covered. It's not a blocker, since it is not done in other similar tests nor in the iterator-based tests. We can leave a TODO and create an issue.
akukanov
force-pushed
the
dev/ranges-replace-copy-akukanov
branch
from
4ed22f6 to
99615d4
Compare
dmitriy-sobolev
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial implementation used unary
transformunderneath, but, as the discussion in comments revealed, that would impose extra requirements on one or more of the data types. The final implementation uses an appropriate "walk" pattern with__replace_copy_functor.