Bugfix incorrect __get_sycl_range#2520
Merged
Merged
Conversation
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where incorrect variable names were used when creating SYCL ranges for output iterators in the radix_sort_by_key function. The variables __keys_keep and __vals_keep were mistakenly used instead of the correctly declared __keys_out_keep and __vals_out_keep.
Key Changes:
- Corrected variable reference from
__keys_keepto__keys_out_keepon line 164 - Corrected variable reference from
__vals_keepto__vals_out_keepon line 167
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dmitriy-sobolev
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2519 I found an issue in esimd_radix_sort_by_key where the wrong
__get_sycl_rangestruct was used for keys_out and vals_out.This should be fixed for the coming release, where that is targeted at a future release.