Skip to content

[do not merge] Raise CI errors in test.sh#3574

Draft
ethanglaser wants to merge 2 commits intouxlfoundation:mainfrom
ethanglaser:dev/eglaser-raise-ci-errors
Draft

[do not merge] Raise CI errors in test.sh#3574
ethanglaser wants to merge 2 commits intouxlfoundation:mainfrom
ethanglaser:dev/eglaser-raise-ci-errors

Conversation

@ethanglaser
Copy link
Copy Markdown
Contributor

Description


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@ethanglaser ethanglaser force-pushed the dev/eglaser-raise-ci-errors branch from 327ff45 to 449bc49 Compare March 20, 2026 21:26
Copy link
Copy Markdown
Contributor

@david-cortes-intel david-cortes-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but don't know what to do about the errors. Will defer to @Alexandr-Solovev .

@ethanglaser
Copy link
Copy Markdown
Contributor Author

@theComputeKid FYI the Arm-hosted examples are all failing with illegal instruction. We aren't sure when the regression occurred because the examples were enabled with || true when this was initially added and have been silently failing for months. Is this something you can investigate? We are wondering whether it makes sense to try to fix these or drop them entirely, but don't have much bandwidth from our end to investigate

@theComputeKid
Copy link
Copy Markdown
Member

theComputeKid commented Mar 24, 2026

@murste01 @Sqvid @Radu2k Could you please take a look.

@ethanglaser
Copy link
Copy Markdown
Contributor Author

CI Failure Triage Report

Run: 23363249154 | Date: 2026-03-20

Failed Jobs: Please include labels on your pull request

Analysis

CI Failure Analysis

1. Failure Classification: PR-specific

2. Root Cause: Missing PR labels requirement

The failure is caused by a repository policy that requires pull requests to have labels applied. The CI job specifically checks for labels and fails if none are present (or only "RFC" label exists).

3. Evidence

From the error log:

LABELS=`gh api -H "Accept: application/vnd.github+json" /repos/uxlfoundation/oneDAL/issues/3574/labels | jq '[.[].name]'`
echo $LABELS
# Output: []
if [[ $LABELS == "[]" ]] || [[ $LABELS == "[\"RFC\"]" ]]; then
  echo "::error::No label set on the pull request"
  exit 1
fi

The API call returns an empty array [], indicating no labels are set on PR #3574.

4. Relevant Code Changes: None

The code changes in the diff (removing || true from test commands and fixing shell syntax) are not related to this failure. The failure is purely due to missing PR labels, which is a repository governance requirement.

5. Recommendation

Immediate action: The PR author should add appropriate labels to PR #3574. Common labels might include:

  • Component labels (e.g., build, ci, testing)
  • Type labels (e.g., enhancement, bug, maintenance)
  • Priority labels if available

Note: The actual code changes in this PR appear valid - they remove error suppression (|| true) from test commands and fix a shell syntax error (missing quote in the grep pattern), which are good improvements for making CI failures more visible.


Similar failures in recent runs

No similar failures found in recent runs.


Generated by CI Triage Bot

@Sqvid
Copy link
Copy Markdown

Sqvid commented Mar 25, 2026

I haven't had time to look into this in detail but at first glance it does strike me as odd that you are building with --optimizations sve (which I assume builds SVE-specific code):

.ci/scripts/build.sh --compiler ${{ matrix.os.cxx }} --optimizations sve --target daal --backend-config ref --tbb-dir $TBBROOT --blas-dir ./__deps/openblas_aarch64

and then running on a c6g machine, which is Neoverse N1 and therefore does not support SVE.

Unless you explicitly have code to gracefully handle runtime dispatch it would be expected to encounter SIGILL when executing SVE instructions on a Neoverse N1 system.


- name: make daal
run: |
.ci/scripts/build.sh --compiler ${{ matrix.os.cxx }} --optimizations sve --target daal --backend-config ref --tbb-dir $TBBROOT --blas-dir ./__deps/openblas_aarch64
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.ci/scripts/build.sh --compiler ${{ matrix.os.cxx }} --optimizations none --target daal --backend-config ref --tbb-dir $TBBROOT --blas-dir ./__deps/openblas_aarch64

@ethanglaser ethanglaser changed the title Raise CI errors in test.sh [do not merge] Raise CI errors in test.sh Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants