-
Notifications
You must be signed in to change notification settings - Fork 224
[conda] Split GPU runtime into dal-gpu package #3551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
napetrov
wants to merge
25
commits into
uxlfoundation:main
Choose a base branch
from
napetrov:conda/dal-gpu-split
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 20 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
1c750c6
conda: split GPU runtime into dal-gpu package
napetrov 154290a
conda: move all *_dpc runtime libs to dal-gpu
napetrov 836c9fd
conda: ensure libtbb.so symlink exists in build env
napetrov fbad392
conda: fix libtbb.so symlink in test-devel.sh for MKL cmake find
napetrov 94c46d3
conda: fix dal-gpu skip selector (use build.skip instead of name sele…
napetrov 4cd9548
conda: fix TBB cmake detection for DPC++ examples (set TBB_tbb_FOUND=…
napetrov 545a2ae
conda: hardcode oneapi/dpc example validation to dynamic mode
napetrov 0762753
conda: tighten dal-gpu split packaging/test robustness
napetrov bf4b405
conda: fix test-devel.sh shebang and mkdir idempotency
napetrov 54c0409
Merge branch 'main' into conda/dal-gpu-split
Alexandr-Solovev 5b5fff7
conda: add mkl runtime dependency for dal-gpu
napetrov 360a36f
conda: harden dal-gpu packaging and devel tests
napetrov 2e1cf61
conda: mirror all libtbb* libs into TBBROOT staging (fix libtbbmalloc…
napetrov 3d3f8d9
Merge branch 'main' into conda/dal-gpu-split
Alexandr-Solovev ab49f00
conda: fix dal-gpu runtime deps: use intel-sycl-rt and mkl-dpcpp
napetrov 7914632
conda: fix example data path in dal-devel tests
napetrov b6a4d71
conda: make dal-devel example data lookup robust in CI test env
napetrov 96d5c4e
conda: install example data into dal-devel package and fix test data …
napetrov c65e1bc
conda: use per-output ignore_run_exports_from for intel-sycl-rt
napetrov 4864b64
conda: ignore dpcpp_impl run_exports for all non-GPU outputs
napetrov 0a3871d
Merge branch 'main' into conda/dal-gpu-split
Alexandr-Solovev 382f101
conda: clarify dal-devel data install path comment
napetrov 65763ca
conda: make test script POSIX and stabilize dataset source path
napetrov c5ddfe8
conda: fix remaining review issues for dal-gpu/devel packaging
napetrov a7785f9
Merge branch 'main' into conda/dal-gpu-split
Alexandr-Solovev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,8 +34,12 @@ build: | |
| number: {{ buildnumber }} | ||
| string: h{{ git_hash }}_{{ buildnumber }}_{{ cxx_compiler }} | ||
| include_recipe: False | ||
| ignore_run_exports_from: | ||
| - dpcpp_impl_linux-64 # [linux64 or win] | ||
| # Note: ignore_run_exports_from is NOT set globally here. | ||
| # It is set per-output: dal (CPU) ignores dpcpp_impl run_exports so it | ||
david-cortes-intel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # does not pull GPU/SYCL runtime. dal-gpu does NOT ignore them, so it | ||
| # automatically inherits the compatible intel-sycl-rt pin declared by | ||
| # dpcpp_impl_linux-64 via run_exports, keeping SYCL runtime in sync | ||
| # with the compiler used at build time. | ||
| script_env: | ||
| # All build targets are used by default and AVX2 only for CI. | ||
| # Override REQCPU to reduce manual build time if needed: `REQCPU=avx512 conda build .` | ||
|
|
@@ -62,19 +66,47 @@ requirements: | |
|
|
||
| outputs: | ||
| - name: dal | ||
| build: | ||
| # Suppress dpcpp_impl run_exports for the CPU-only package: | ||
| # dal must not pull GPU/SYCL runtime (intel-sycl-rt). | ||
| ignore_run_exports_from: | ||
| - dpcpp_impl_linux-64 # [linux64 or win] | ||
| script: pack.sh # [linux] | ||
| requirements: | ||
| run: | ||
| - tbb | ||
| test: | ||
| commands: | ||
| - test -f $PREFIX/lib/libonedal_core.so.{{ major_binary_version }} # [linux] | ||
| - test -f $PREFIX/lib/libonedal_dpc.so.{{ major_binary_version }} # [linux] | ||
| - test -f $PREFIX/lib/libonedal_thread.so.{{ major_binary_version }} # [linux] | ||
| about: | ||
| summary: oneAPI Data Analytics Library (oneDAL) runtime libraries | ||
| summary: oneAPI Data Analytics Library (oneDAL) CPU runtime libraries | ||
|
|
||
| - name: dal-gpu | ||
| build: | ||
| skip: true # [cxx_compiler != "dpcpp" or not linux64] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one has: But |
||
| # Do NOT set ignore_run_exports_from here: dpcpp_impl_linux-64 declares | ||
| # run_exports with a compatible intel-sycl-rt pin. dal-gpu inherits it | ||
| # automatically — no manual pin needed. | ||
| script: pack.sh # [linux] | ||
david-cortes-intel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| requirements: | ||
| run: | ||
| - {{ pin_subpackage('dal', exact=True) }} | ||
| # intel-sycl-rt is intentionally absent from the explicit run: list. | ||
| # It is injected automatically via run_exports from dpcpp_impl_linux-64, | ||
| # ensuring the SYCL runtime version matches the compiler used to build. | ||
| - mkl-dpcpp # [linux64] | ||
david-cortes-intel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| test: | ||
| commands: | ||
| - test -f $PREFIX/lib/libonedal_dpc.so.{{ major_binary_version }} # [linux] | ||
| - test -f $PREFIX/lib/libonedal_parameters_dpc.so.{{ major_binary_version }} # [linux] | ||
| about: | ||
| summary: oneAPI Data Analytics Library (oneDAL) GPU/DPC++ runtime library | ||
|
|
||
| - name: dal-include | ||
| build: | ||
| ignore_run_exports_from: | ||
| - dpcpp_impl_linux-64 # [linux64 or win] | ||
| script: pack.sh # [linux] | ||
| test: | ||
| commands: | ||
|
|
@@ -83,6 +115,9 @@ outputs: | |
| summary: Headers for building against oneAPI Data Analytics Library (oneDAL) | ||
|
|
||
| - name: dal-static | ||
| build: | ||
| ignore_run_exports_from: | ||
| - dpcpp_impl_linux-64 # [linux64 or win] | ||
| script: pack.sh # [linux] | ||
| requirements: | ||
| run: | ||
|
|
@@ -95,6 +130,9 @@ outputs: | |
| summary: Static libraries for oneAPI Data Analytics Library (oneDAL) | ||
|
|
||
| - name: dal-devel | ||
| build: | ||
| ignore_run_exports_from: | ||
david-cortes-intel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - dpcpp_impl_linux-64 # [linux64 or win] | ||
| script: pack.sh # [linux] | ||
| requirements: | ||
| run: | ||
|
|
@@ -109,6 +147,7 @@ outputs: | |
| - mkl-devel | ||
| - mkl-static | ||
| - mkl-devel-dpcpp # [ cxx_compiler == "dpcpp" ] | ||
| - dal-gpu =={{ version }} # [ cxx_compiler == "dpcpp" ] | ||
napetrov marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| source_files: | ||
| - examples | ||
| script: test-devel.sh # [linux] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.