-
Notifications
You must be signed in to change notification settings - Fork 224
bazel: add release structure improvements (versioning, SONAME, vars.sh, pkg-config) #3513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
napetrov
wants to merge
28
commits into
uxlfoundation:main
Choose a base branch
from
napetrov:bazel/release-structure-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
b4d3948
bazel: add release structure improvements
napetrov 87aad6c
bazel: fix CI issues
napetrov ff6aa6a
bazel: fix Copilot review issues
napetrov 544bfa7
bazel: address remaining Copilot review comments
napetrov 38f02dc
bazel: fix DAAL release_dynamic runfiles/SONAME resolution
napetrov b0a5201
bazel: address Copilot round-3 review feedback
napetrov 98edf09
bazel: fix Bzlmod repo mapping in transition and escape format string
napetrov 3584237
bazel: read binary ABI version from makefile.ver instead of hardcoding
napetrov dcb0115
bazel: remove cc_dynamic_lib SONAME fallback, fix docstrings
napetrov 2caa303
bazel: fix MKL sandbox link failure in examples
napetrov d8a96f8
bazel: add daal core_static dependency for dev link mode tests
napetrov 8283906
bazel: fix MKL static archive order for dev-mode DAAL example link
napetrov da99a6e
Merge branch 'main' into bazel/release-structure-improvements
Alexandr-Solovev 17d08a9
upd daal examples and test ci job for sklearnex with bazel build
Alexandr-Solovev 07cbc08
fixes for ci
Alexandr-Solovev c056eb5
Merge branch 'main' into bazel/release-structure-improvements
Alexandr-Solovev ce9f29c
Address Copilot review comments on #3513
napetrov dbb3c4f
bazel: allow empty DPC runtime globs in onedal_release repo
napetrov bbdc7e6
bazel: restore MKL static deps for onedal_dynamic
napetrov 730e0f5
remove ci validation for bazel build with sklearnex
Alexandr-Solovev 2e27193
Merge branch 'main' into bazel/release-structure-improvements
Alexandr-Solovev debee1b
bazel: fix external headers leaking into release include/
napetrov bb74239
bazel: fix onedal_dynamic glob to avoid duplicate .so link inputs
napetrov 90618ae
bazel: fix include layout and exclude daal_win.h from Linux release
napetrov 0c84638
bazel: set SONAME for shared libs via VersionInfo
napetrov a169446
bazel: address review comments (ASCII output, Linux guard, dal_exampl…
napetrov 5b48c26
restore for fix the public ci step
Alexandr-Solovev d023fa9
Merge branch 'main' into bazel/release-structure-improvements
Alexandr-Solovev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #=============================================================================== | ||
| # Copyright contributors to the oneDAL project | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| #=============================================================================== | ||
|
|
||
| package(default_visibility = ["//visibility:public"]) | ||
|
|
||
| exports_files([ | ||
| "vars_lnx.sh", | ||
| "vars_mac.sh", | ||
| "vars_win.bat", | ||
| ]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| #=============================================================================== | ||
| # Copyright contributors to the oneDAL project | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| #=============================================================================== | ||
|
|
||
| package(default_visibility = ["//visibility:public"]) | ||
|
|
||
| exports_files([ | ||
| "pkg-config.cpp", | ||
| ]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//:releasenow always depends onrelease_vars_shandrelease_pkgconfig. If//:releaseis built on unsupported platforms (e.g., Windows), these targets will currently generate Unix shell artifacts and/or requiregcc. Consider guarding these with platform constraints or adding a Windows-specific implementation before making them unconditional.