Skip to content

ENH: Ridge Regression CPU SPMD support#3506

Draft
DDJHB wants to merge 5 commits intouxlfoundation:mainfrom
DDJHB:dev_ridge_cpu_spmd
Draft

ENH: Ridge Regression CPU SPMD support#3506
DDJHB wants to merge 5 commits intouxlfoundation:mainfrom
DDJHB:dev_ridge_cpu_spmd

Conversation

@DDJHB
Copy link
Copy Markdown
Contributor

@DDJHB DDJHB commented Feb 9, 2026

Description

This PR adds distributed (SPMD) training support for Ridge Regression on CPU, following Linear Regression changes.


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@DDJHB
Copy link
Copy Markdown
Contributor Author

DDJHB commented Feb 9, 2026

/intelci: run

}

TEMPLATE_LIST_TEST_M(lr_spmd_test, "RR common flow", "[rr][spmd]", lr_types) {
SKIP_IF(this->not_float64_friendly());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it need to skip this one if it's on CPU?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is common for CPU and GPU and this check is necessary just for GPU without native float64 support

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DDJHB @Alexandr-Solovev it would be better to add if_gpu condition then.

@DDJHB
Copy link
Copy Markdown
Contributor Author

DDJHB commented Mar 29, 2026

/intelci: run

}

TEMPLATE_LIST_TEST_M(lr_spmd_test, "RR common flow", "[rr][spmd]", lr_types) {
SKIP_IF(this->not_float64_friendly());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SKIP_IF(this->not_float64_friendly());
#ifdef ONEDAL_DATA_PARALLEL
SKIP_IF(this->not_float64_friendly());
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants