Repository navigation
Acl dev full panics - #313
Merged
Merged
Conversation
oech3
reviewed
Jun 24, 2026
| /// - The command should handle the write error gracefully | ||
| #[test] | ||
| #[cfg(any(target_os = "linux", target_os = "freebsd", target_os = "netbsd"))] | ||
| fn test_acl_binary_write_error_to_dev_full_no_panic() { |
Contributor
There was a problem hiding this comment.
Suggested change
| fn test_acl_binary_write_error_to_dev_full_no_panic() { | |
| fn test_acl_binary_write_error_no_panic() { |
Signed-off-by: Malhar Vora <mlvora.2010@gmail.com>
Signed-off-by: Malhar Vora <mlvora.2010@gmail.com>
Signed-off-by: Malhar Vora <mlvora.2010@gmail.com>
Signed-off-by: Malhar Vora <mlvora.2010@gmail.com>
vbmade2000
force-pushed
the
acl_dev_full_panics
branch
from
June 27, 2026 03:10
a46c4e4 to
3d1fa89
Compare
Contributor
Author
|
@oech3 Can you please re-review it? |
Contributor
|
I have no priv to merge this.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #254.
Solution: Use
writelnto put data instdoutinstead of usingprintlndirectly.