ci: create a GitHub Release on tag - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
releasejob to the tag-triggered pipeline so a GitHub Release is created automatically alongside the registry publish.Why
Only
go-sdkandhaskell-sdkcreate GitHub Releases today; the other four pipelines end atpublish. The result is that published packages have no corresponding release entry —python-sdkandrust-sdkhad none at all, anddotnet-sdk/node-sdkhad histories that simply stop where the May 2026 rewrite replaced the old workflows and dropped the step.Today's tags were backfilled by hand. This makes it automatic.
Shape
Two deliberate choices:
publish.haskell-sdkdoes it inline, but on the OIDC pipelines (node-sdk,dotnet-sdk)publishruns withcontents: readon purpose. Adding a release step there would mean widening the credential-bearing job tocontents: write. Keeping it separate preserves least privilege, and the same shape is applied across all four repos for consistency.prereleasederived from the tag. A SemVer pre-release suffix is the only place a hyphen appears in these tags, sov1.8.0-alphais marked pre-release andv0.9.0is not, with no per-repo configuration.needs: publishmeans no release entry appears if the registry push fails — the release reflects what actually shipped.Scope
No change to
verify,build,test,publish, thev*trigger, or any credential. Contract-wise this is additive: §2 mandates build/test/publish and §5 lists release notes as aspirational, so nothing was in violation — but the inconsistency is being closed deliberately, with a companionu5c-factoryPR stating the requirement.🤖 Generated with Claude Code