-
Notifications
You must be signed in to change notification settings - Fork 7
Improve GitHub branch listing pagination #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HarshMN2345
wants to merge
17
commits into
main
Choose a base branch
from
feature/github-branch-search-pagination
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
385420b
Improve GitHub branch listing pagination
HarshMN2345 be94f82
Use prefix search for GitHub branches
HarshMN2345 364c1f6
Honor branch pagination in other adapters
HarshMN2345 6e63c0a
Preserve default branch listing behavior
HarshMN2345 f85fa75
Unify listBranches return shape across all adapters
HarshMN2345 09c3882
fix: update testListBranchesEmptyRepo assertions to structured shape
HarshMN2345 98e2e9b
fix: update listBranches docblocks in Gitea and Gogs to fix PHPStan e…
HarshMN2345 a63ae11
fix: use GraphQL query param for branch prefix search instead of refP…
HarshMN2345 ca33d73
fix: enforce prefix search semantics and fix Gogs branch existence scan
HarshMN2345 1bfc5c4
fix: use per-edge cursors and probe loop to guarantee items never emp…
HarshMN2345 a9f1df7
fix: remove N-sequential-call loop; GitHub pagination is cursor-only
HarshMN2345 e519452
fix: tolerate null author in getLatestCommit for GitHub App commits
HarshMN2345 ba15102
Inline listBranchesPage into listBranches — remove single-use helper
HarshMN2345 a4adbc5
Document why GraphQL is used over REST in listBranches
HarshMN2345 2bce5fe
Use GitLab server-side prefix search in listBranches
HarshMN2345 9275809
Rename \$page to \$requestedPage in Gogs listBranches for clarity
HarshMN2345 f51aa66
Document that Gitea has no server-side branch search in listBranches
HarshMN2345 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, does Gitea have refs endpoints too? I recall they try to be compatible with GitHub, I would expect we can urilize same thing there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, Gitea does not support server-side branch filtering
Parameters like q or search are ignored server-side (verified against Codeberg/Forgejo). Since Gitea also lacks GraphQL support, fetching all branches and filtering client-side is currently unavoidable. Added a comment documenting this behavior.