Skip to content

fix(rules/o365): remove duplicate o365 admin role assignment rule and update canonical one#2244

Merged
Kbayero merged 1 commit into
v11from
hotfix/fix-rule-o365-role-assignment
Jun 25, 2026
Merged

fix(rules/o365): remove duplicate o365 admin role assignment rule and update canonical one#2244
Kbayero merged 1 commit into
v11from
hotfix/fix-rule-o365-role-assignment

Conversation

@JocLRojas

Copy link
Copy Markdown
Contributor

Detailed explanation of the changes

This PR cleans up a duplicate correlation rule in the Office 365 ruleset and aligns the canonical rule with the project naming convention.

  • Removed: rules/office365/o365_admin_role_assignment.yml.
  • Modified: rules/office365/o365-admin-role-assignment.yml — updated to keep the correct detection logic.

Reasoning

Two rule files were detecting the same Office 365 admin role assignment activity, causing duplicate alerts and confusion in the rule catalog.

Issue reference

N/A

@JocLRojas JocLRojas requested a review from a team June 19, 2026 16:26
@github-actions

Copy link
Copy Markdown

❌ Go dependencies check failed

There are outdated Go dependencies, or modules that could not be inspected.
Run bash .github/scripts/go-deps.sh --update --discover locally and
commit the updated go.mod / go.sum files.

Script output
🔍 Discovered 25 Go projects

📦 Dependencies with updates available:

  📁 ./plugins/modules-config:
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.76.0 → v1.77.0

  📁 ./plugins/aws:
     - github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs: v1.76.0 → v1.77.0

�[0;31m❌ Please update dependencies before merging.�[0m

@github-actions

Copy link
Copy Markdown

✅ AI review — Approved

No issues detected in this diff.

architecture (gemini-3-flash-lite) — clean

Summary: No reviewable changes in this diff (excluded paths only).

No findings.

bugs (gemini-3-flash-lite) — clean

Summary: No reviewable changes in this diff (excluded paths only).

No findings.

security (gemini-3-flash-lite) — clean

Summary: No reviewable changes in this diff (excluded paths only).

No findings.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — Go dependencies check failed (see above).

@Kbayero Kbayero merged commit 7a5e65f into v11 Jun 25, 2026
5 of 7 checks passed
@Kbayero Kbayero deleted the hotfix/fix-rule-o365-role-assignment branch June 25, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants