execute global initialization after all the other declarations have finished#2740
Merged
jurgenvinju merged 2 commits intomainfrom Apr 1, 2026
Merged
execute global initialization after all the other declarations have finished#2740jurgenvinju merged 2 commits intomainfrom
jurgenvinju merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2740 +/- ##
=======================================
- Coverage 46% 46% -1%
+ Complexity 6721 6719 -2
=======================================
Files 794 794
Lines 65905 65910 +5
Branches 9884 9887 +3
=======================================
- Hits 30827 30819 -8
- Misses 32690 32700 +10
- Partials 2388 2391 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DavyLandman
approved these changes
Mar 31, 2026
3 tasks
Member
Author
|
ok a test was added. I'm merging as soon as it builds here. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR partially fixes this situation:
Because at the time of running the initialization for
xthe second overload is not there yet, the answer tof(0)will be42(and thefwill be cached but that is for #2741). While the test is running, bothxandf(0)will return the wrong number.It is the goal of this PR to fix the value of
x. The fix forf(0)in the test is in #2741