#2346 redone: a formatter for Rascal itself, plus the necessary improvements and stabilization in the Box formatter framework code.#2738
Open
jurgenvinju wants to merge 20 commits intomainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2738 +/- ##
=======================================
Coverage 46% 46%
- Complexity 6725 6732 +7
=======================================
Files 794 794
Lines 65923 65936 +13
Branches 9888 9888
=======================================
+ Hits 30837 30853 +16
+ Misses 32696 32693 -3
Partials 2390 2390 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
toinehartman
reviewed
Apr 8, 2026
…igate the loss of the automatic assert
Member
Author
|
thanks for the review @toinehartman . Before we merge, some of the TODOs @toinehartman highlighted should be checked. See the conversation above. |
|
Member
Author
|
@DavyLandman this seems ready. lots of fixes in Box-related code, fixed in layoutDif, and new features for Rascal formatting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is a redo of #2346 which was mangled due to a wrong use of git-filter-repo.
Rascal is a pretty big language so this pushes the new
toBoxandformatandlayoutDifffunctions to the max.toBoxrules such that the formatter produces beautiful layout, andtoBox,formatandlayoutDiffand fix them immediately.