Merged
Conversation
- Removed unused properties - Added property tpl_from_library: used to block recompilation of library modules - Added utility functions for handling properties: hasProperty, hasAnyProperty, hasNotProperty, addProperty, deleteProperty - Replaced handling of properties by the above functions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2732 +/- ##
=======================================
Coverage 46% 46%
+ Complexity 6729 6726 -3
=======================================
Files 794 794
Lines 65905 65905
Branches 9883 9883
=======================================
+ Hits 30828 30832 +4
+ Misses 32690 32687 -3
+ Partials 2387 2386 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the presence of a binary library, a second attempt to check a module could fail.
This fixes #2711
The solution is to distinguish the case that a TModel comes from a library and block rechecking. As a side effect, some renaming and refactoring has been done.