Skip to content

Fixing issue 916 on URI path interpolation#1802

Draft
jurgenvinju wants to merge 6 commits intomainfrom
issue916
Draft

Fixing issue 916 on URI path interpolation#1802
jurgenvinju wants to merge 6 commits intomainfrom
issue916

Conversation

@jurgenvinju
Copy link
Copy Markdown
Member

@jurgenvinju jurgenvinju commented Jun 1, 2023

@jurgenvinju
Copy link
Copy Markdown
Member Author

This one was open since 2015, but now more and more people get confused by it. It's probably because of the increased usage of clair which has path interpolation in its source code. Seems like a good time as any to fix it. At least we have some tests for it now.

Copy link
Copy Markdown
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RascalJUnitTestRunner changes confuse me a bit.

@jurgenvinju jurgenvinju marked this pull request as draft June 1, 2023 14:27
@jurgenvinju
Copy link
Copy Markdown
Member Author

The current solution is broken. Another test for toLocation shows that the current way of interpolating path strings also introduces an extra / even if the interpolation is in the authority part of a URI.

  • Have to figure out a way to see if we are already in the path part somehow during the interpolation process.
  • Have to make sure we encode differently in the authority part then in the path part.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 9, 2026

@jurgenvinju
Copy link
Copy Markdown
Member Author

We can continue this where we left off in 2023. The current PR improves on the situation, where it encodes interpolated values better than before, but we still have to distinguish better between the "authority" and the "path" part of the URI we are building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loc splicing does not build URIs the right way (e.g. spaces end up being not encoded when the loc is printed)

2 participants