Skip to content

fix universal: fix incorrect initializer-list constructor of AtomicFlags #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddvamp wants to merge 2 commits into
base: develop
Choose a base branch
from
+335 −2
Open

fix universal: fix incorrect initializer-list constructor of AtomicFlags #1201

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dda067f
fix universal: fix incorrect initializer-list constructor of AtomicFlags
ddvamp Apr 25, 2026
c26ee9f
test universal: add tests for Flags and AtomicFlags
ddvamp Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions universal/include/userver/utils/flags.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ class AtomicFlags final {
constexpr AtomicFlags()
: AtomicFlags(Enum::kNone)
{}
constexpr explicit AtomicFlags(Flags<Enum>);
Copy link
Copy Markdown
Member

@apolukhin apolukhin Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests , showingand testing the problem

constexpr explicit AtomicFlags(Enum);
constexpr AtomicFlags(std::initializer_list<Enum>);

Expand Down Expand Up @@ -217,14 +218,19 @@ constexpr bool operator!=(Enum lhs, Flags<Enum> rhs) {
return rhs != Flags<Enum>{lhs};
}

template <typename Enum>
constexpr AtomicFlags<Enum>::AtomicFlags(Flags<Enum> flags)
: value_(flags.GetValue())
{}

template <typename Enum>
constexpr AtomicFlags<Enum>::AtomicFlags(Enum value)
: value_(static_cast<ValueType>(value))
: AtomicFlags(Flags<Enum>(value))
{}

template <typename Enum>
constexpr AtomicFlags<Enum>::AtomicFlags(std::initializer_list<Enum> values)
: AtomicFlags(Enum(values))
: AtomicFlags(Flags<Enum>(values))
{}

template <typename Enum>
Expand Down