Skip to content

Fix Java upload examples in LIBRARY.md - #168

Open
alxgsv wants to merge 1 commit into
masterfrom
docs/fix-library-md-java-examples
Open

Fix Java upload examples in LIBRARY.md#168
alxgsv wants to merge 1 commit into
masterfrom
docs/fix-library-md-java-examples

Conversation

@alxgsv

@alxgsv alxgsv commented Jul 8, 2026

Copy link
Copy Markdown

Java snippets for FileUploader and UrlUploader did not compile:

  • onProgressUpdate must use primitive long/double to override the Kotlin interface method
  • Uploader.upload() has a Kotlin default parameter that is not visible from Java, so the call requires an explicit argument

Summary by CodeRabbit

  • Documentation
    • Updated upload examples to match the latest callback parameter types.
    • Clarified synchronous upload usage by showing an explicit null argument in examples.

Java snippets for FileUploader and UrlUploader did not compile:
- onProgressUpdate must use primitive long/double to override the
  Kotlin interface method
- Uploader.upload() has a Kotlin default parameter that is not
  visible from Java, so the call requires an explicit argument
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d877a815-d512-4852-9f0d-55486d2f3b0a

📥 Commits

Reviewing files that changed from the base of the PR and between 1fe0e17 and f2493cf.

📒 Files selected for processing (1)
  • documentation/LIBRARY.md

Walkthrough

Documentation code snippets in documentation/LIBRARY.md were updated: Java onProgressUpdate callback parameters changed from boxed types (Long, Double) to primitives (long, double), and synchronous upload examples now pass an explicit null argument to uploader.upload().

Changes

Upload documentation examples

Layer / File(s) Summary
Progress callback parameter types
documentation/LIBRARY.md
onProgressUpdate callback parameters in async upload examples (file and URI) changed from boxed Long/Double to primitive long/double.
Synchronous upload call signature
documentation/LIBRARY.md
Synchronous upload examples (file and URI) updated from uploader.upload() to uploader.upload(null).

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the documentation fix for Java upload examples in LIBRARY.md.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/fix-library-md-java-examples

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant