-
Notifications
You must be signed in to change notification settings - Fork 8
Marketplace auth updates #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tr0njavolta
wants to merge
5
commits into
upbound:main
Choose a base branch
from
tr0njavolta:marketplace-auth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Marketplace auth updates #1182
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b334d6a
Updates marketplace auth instructions
tr0njavolta 9917c11
Signed-off-by: Rae Sharp <resharp20@gmail.com>
tr0njavolta 6efb6c4
add crossplane cli link
tr0njavolta c6ec444
Vale
tr0njavolta fe1be9c
update with review comments
tr0njavolta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the credential helper is meant to support Marketplace interactions via a fresh session with
up login. so that's still a valid alternative to robot tokens. might be worth making this a preamble to the section starting on L51 to make sure users pick one or the other to avoid them conflicting.