[Android] Fix java NRE handing touch events on detached view#1571
Merged
Conversation
This fixes an issue with the AutosuggestBox, but should be tested one unoplatform/Uno.UITest#19 is fixed.
jeromelaban
changed the title
agneszitte
approved these changes
Sep 23, 2019
davidjohnoliver
approved these changes
Sep 23, 2019
Contributor
davidjohnoliver
left a comment
davidjohnoliver
left a comment
There was a problem hiding this comment.
UI test would be nice
Member
Author
|
@davidjohnoliver |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): unoplatform/Uno.WindowsCommunityToolkit#59 (comment)
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Touching an element in an
AutoSuggestBoxmay crash the application.What is the new behavior?
The application does not crash.
This PR should be tested once unoplatform/Uno.UITest#19 is fixed.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):