Skip to content

Replace portals with Popover API for layering #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NullVoxPopuli-ai-agent wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Replace portals with Popover API for layering #722

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
63205ca
Replace portals with Popover API for layering
NullVoxPopuli Apr 10, 2026
6bfaa23
Fix popover UA style overrides
NullVoxPopuli Apr 10, 2026
bd5078f
Use dialog element for nested popover in demo
NullVoxPopuli Apr 10, 2026
84a1371
Fix nested popover stacking order
NullVoxPopuli Apr 11, 2026
b949def
Add disabled button tooltip demo
NullVoxPopuli Apr 11, 2026
1414c9b
Remove unnecessary @as="dialog" from tooltip demo
NullVoxPopuli Apr 11, 2026
cc04684
Always use <dialog> for Content element
NullVoxPopuli Apr 11, 2026
64147ea
Fix CI: add pnpm i -f to Setup job + update tooltip demo copy
NullVoxPopuli Apr 11, 2026
d129b61
Fix lint: add blank line before if statement
NullVoxPopuli Apr 11, 2026
b08c166
Fix CI: ensure ember-tsc binary exists before build
NullVoxPopuli Apr 11, 2026
a40e948
Style tooltip demo: center button, match floatybit style
NullVoxPopuli Apr 11, 2026
b78325c
Fix dark mode styles for header demo
NullVoxPopuli Apr 11, 2026
f95f6cc
Match dark mode colors to site palette
NullVoxPopuli Apr 11, 2026
3f19766
Switch Content back to <div> from <dialog>
NullVoxPopuli Apr 11, 2026
8cc83f0
Restore @as arg for Content element
NullVoxPopuli Apr 11, 2026
3f644cc
Address PR review comments + add migration guide
NullVoxPopuli Apr 12, 2026
2a65cfd
Auto-focus popover content with tabindex after showPopover
NullVoxPopuli Apr 12, 2026
f018c5c
Address review: auto-add open for @as="dialog", fix migration docs
NullVoxPopuli Apr 12, 2026
3816d65
Fix migration diff: PortalTargets is from portal-targets, not popover
NullVoxPopuli Apr 12, 2026
b7a31a1
Fix Menu focus in top layer
NullVoxPopuli Apr 12, 2026
5bcc058
Use requestAnimationFrame with isConnected check for focus
NullVoxPopuli Apr 12, 2026
2b357a0
Move focus management from Popover to Menu
NullVoxPopuli Apr 12, 2026
8412b8e
Use popover toggle event for Menu focus instead of Promise.resolve
NullVoxPopuli Apr 12, 2026
08d88ab
Add MDN link for toggle event
NullVoxPopuli Apr 12, 2026
33b1093
Remove PortalTargets from Menu docs + add migration guide
NullVoxPopuli Apr 12, 2026
dd40018
Fix CI: add pnpm i -f before build in Lint job
NullVoxPopuli Apr 12, 2026
a54b2fb
Clarify CSS considerations refer to [popover] attribute, not <dialog>
NullVoxPopuli Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
- uses: wyvox/action@v2
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
- run: pnpm i -f # ensure all bin symlinks are created
- run: pnpm build
- id: set-pending
run: echo "pending=$(./cache-status.sh)" >> $GITHUB_OUTPUT
Expand Down
Loading
Loading