Skip to content

feat: Add conversion between jeff and Qiskit #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kawacukennedy wants to merge 8 commits into from
Closed

feat: Add conversion between jeff and Qiskit #64

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f1a6d64
feat: add jeff ↔ Qiskit QuantumCircuit converter
kawacukennedy Jun 4, 2026
c366625
feat: rewrite Qiskit converter in C++ with capnp + Qiskit C API
kawacukennedy Jun 5, 2026
d179633
Address PR #64 review: direct linking, data-driven gates, build-time …
kawacukennedy Jun 6, 2026
963c31c
fix: revert auto-generated capnp files to main (use v1.3.0) to fix re…
kawacukennedy Jun 6, 2026
7c5371f
fix: skip qiskit_convert tests if Qiskit not installed (prevents CI f…
kawacukennedy Jun 6, 2026
4d7514c
fix: apply ruff format and fix F541 lint in test file
kawacukennedy Jun 6, 2026
bb84316
fix: Address PR #64 review: use shared capnp, qubit allocs, cleaner C…
kawacukennedy Jun 8, 2026
cbcecb9
fix: address PR #64 review round 2 — text-format round-trip, comprehe…
kawacukennedy Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/change-filters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ python: &python
- *schema-def
- ".github/workflows/ci-py.yml"
- "impl/py/**"
- "tools/**"
- "pyproject.toml"
- "uv.lock"
- "examples/**/*.py"
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,6 @@ venv/

# MacOS
*.DS_Store

# CMake build directory
build/
601 changes: 289 additions & 312 deletions impl/cpp/src/capnp/jeff.capnp.c++
View file
Open in desktop
Comment thread
denialhaag marked this conversation as resolved.

Large diffs are not rendered by default.

1,224 changes: 611 additions & 613 deletions impl/cpp/src/capnp/jeff.capnp.h
View file
Open in desktop
Comment thread
denialhaag marked this conversation as resolved.

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions impl/py/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,8 @@ packages = ["src/jeff"]
[build-system]
requires = ["hatchling"]
build-backend = "hatchling.build"

[dependency-groups]
dev = [
"pytest",
]
Comment thread
denialhaag marked this conversation as resolved.
Outdated
31 changes: 31 additions & 0 deletions tools/qiskit_convert/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
cmake_minimum_required(VERSION 3.20)
project(jeff-qiskit-convert LANGUAGES CXX)

set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

find_package(PkgConfig REQUIRED)
pkg_check_modules(CAPNP REQUIRED capnp)

set(JEFF_SRC_DIR /tmp/jeff/impl/cpp/src)
set(QISKIT_CAPI_DIR /private/tmp/braket-venv2/lib/python3.12/site-packages/qiskit/capi)
Comment thread
denialhaag marked this conversation as resolved.
Outdated

add_executable(jeff-qiskit-convert
main.cpp
${JEFF_SRC_DIR}/capnp/jeff.capnp.c++
)

target_include_directories(jeff-qiskit-convert PRIVATE
${JEFF_SRC_DIR}
${QISKIT_CAPI_DIR}/include
${CAPNP_INCLUDE_DIRS}
)

target_link_directories(jeff-qiskit-convert PRIVATE
${CAPNP_LIBRARY_DIRS}
)

target_link_libraries(jeff-qiskit-convert PRIVATE
${CAPNP_LIBRARIES}
${CMAKE_DL_LIBS}
)
Loading