Feature/assist 1579 in chat feedback - #1257
Draft
JasperWagen wants to merge 14 commits into
Draft
Conversation
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
JasperWagen
marked this pull request as draft
August 13, 2026 14:11
Contributor
Dependency ReviewThe following issues were found:
OpenSSF Scorecard
Scanned Files
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Trusted server-rendered shell (Jinja-escaped, no LLM content yet). | ||
| // Sanitising here strips the feedback chrome's hx-* attributes. | ||
| // LLM output is sanitised at its own boundary in StreamedContent. | ||
| this.messageContainer.insertAdjacentHTML("beforeend", response.html); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1257 +/- ##
==========================================
+ Coverage 85.50% 86.17% +0.66%
==========================================
Files 231 48 -183
Lines 10493 5280 -5213
==========================================
- Hits 8972 4550 -4422
+ Misses 1521 730 -791 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
JasperWagen
force-pushed
the
feature/ASSIST-1579-in-chat-feedback
branch
from
August 14, 2026 13:17
35ef7b5 to
b786dac
Compare
Signed-off-by: DBT pre-commit check
JasperWagen
force-pushed
the
feature/ASSIST-1579-in-chat-feedback
branch
from
August 14, 2026 13:38
b786dac to
eead6d2
Compare
Signed-off-by: DBT pre-commit check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
https://www.figma.com/file/rrRQhRGkJMCM39F1cvqXsV/Assist-2026?node-id=168%3A21085&fuid=1567178851862477035
feedback redesign
What
adds new feedback journey as per figma designs, with a few necessary deviations
Have you written unit tests?
Are there any specific instructions on how to test this change?
Set enable_feedback_redesign switch in admin pannel
test with and without the switch activated to ensure no regression