-
Notifications
You must be signed in to change notification settings - Fork 18
♻️ Refactor CS coil #4262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chris-ashe
wants to merge
41
commits into
main
Choose a base branch
from
refactor_cs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
♻️ Refactor CS coil #4262
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
737c2c7
Rename hoop_stress method to calculate_cs_hoop_stress and update refe…
chris-ashe f6bbbdc
Enhance CS hoop stress calculation with additional parameters and upd…
chris-ashe 531508f
Refactor CS hoop stress calculation to include additional parameters …
chris-ashe a0117a9
Rename sig_hoop variable to stress_hoop_cs for clarity and update ref…
chris-ashe af2c479
Update CSCoil docstring to clarify parameters and add reference for h…
chris-ashe 007e54f
Rename stress_hoop_cs variable to stress_hoop_cs_inner for clarity an…
chris-ashe bcd69dc
Add stress_hoop_cs_inner_profile variable and update initialization i…
chris-ashe f4d8606
Add a_cs_steel_poloidal variable and update initialization in PF coil…
chris-ashe a9af3b7
Refactor CSCoil to calculate a_cs_steel_poloidal directly and update …
chris-ashe 24cf833
Update output to reference a_cs_steel_poloidal in PF coil module
chris-ashe 430a8c1
Refactor variable names from awpoh to a_cs_cable_space across multipl…
chris-ashe adf644c
Add inner and outer radius variables for central solenoid in PF coil …
chris-ashe 42c9b10
Add radial inner and outer parameters for central solenoid in PF coil…
chris-ashe 6c8022f
Add radial hoop stress profile plotting to CSCoil class and update pa…
chris-ashe b4fc15d
Refactor CSCoil class to add radial stress profile calculations and u…
chris-ashe d94ac7b
Refactor CSCoil class to rename and enhance magnetic field calculatio…
chris-ashe b6b6de1
Add peak field variable for central solenoid bore in PF coil module
chris-ashe 99444c8
Add magnetic field variable for outer edge of central solenoid at mid…
chris-ashe b595e95
Add operating temperature variable for central solenoid and update in…
chris-ashe 3cf202d
Update operating temperature for central solenoid superconductor
chris-ashe aa736e6
Post rebase fixes
chris-ashe 8150c65
Update unit test
chris-ashe 626f2cd
Add CSGeometry dataclass
chris-ashe df3499a
Refactor CS stress plotting functions for clarity and consistency
chris-ashe 6bab6e1
Update docs
chris-ashe 714bc83
:sparkle: Add `a_cs_toroidal` to store the top down cross section
chris-ashe d31b20c
Update CS geometry docs
chris-ashe 618d2e3
Add EU DEMO turn geometry calculations and update tests
chris-ashe 49b9508
Refactor central solenoid variable descriptions for clarity and consi…
chris-ashe 077cce4
Refactor output comments and streamline superconductor information in…
chris-ashe 5804197
Refactor output formatting in PFCoil model for improved readability a…
chris-ashe ff2d094
Update integration test MFILE data to include new CS outputs and prev…
chris-ashe 88af032
Post rebase fixes
chris-ashe 1d5b185
Apply suggestions from code review
chris-ashe b2fb64c
Update type hint for central solenoid radial stress calculation to su…
chris-ashe 3f7b620
Post rebase fixes
chris-ashe 7c496e9
Set Poisson's ratio for steel structure to a constant value of 0.3 in…
chris-ashe 9a3b02e
Test each field of CSGeometry in unit tests
timothy-nunn 371890b
Post rebase fixes
chris-ashe 91e6f7e
Add functions to plot CS radial hoop and radial stress profiles
chris-ashe 8d0dd5a
Refactor CSCoil methods to static and update stress profile plotting …
chris-ashe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting some errors for the equations below, are they displaying ok for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You normally need to just refresh the page and they load