Conversation
eff04b3 to
1ac24dc
Compare
1ac24dc to
d5486bf
Compare
Collaborator
Author
|
After various optimization strategies without seeing any gains, I have decided to put further optimizations for uccl_p2p in this PCIe bottleneck scenario on hold for now. |
ca5f3cd to
220a403
Compare
220a403 to
4856d45
Compare
c2628c1 to
50e5221
Compare
3db49f9 to
d5884fb
Compare
b2d7857 to
71a5272
Compare
71a5272 to
6501951
Compare
38557c3 to
59269d6
Compare
7507963 to
25676b1
Compare
886111e to
f55b6fd
Compare
Collaborator
Author
|
The changes in this PR are too extensive. I'm considering splitting it into multiple PRs to ensure maintainability.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the PCIe bottleneck scenario, i observed that the current P2P bandwidth consistently lags behind NCCL P2P. I attempted to chunk large messages(in uccl_adapter) across multiple engines for parallel transmission, but this failed to break through the limit.
1. UCCL_CACHE_QP_MAX_MSG=0
2. UCCL_CACHE_QP_MAX_MSG=65536
3. UCCL_IB_RELAXED_ORDERING_MODE=1
4. UCCL_IB_RELAXED_ORDERING_MODE=0
5. UCCL_TX_INLINE_THRESHOLD=4096
6. UCCL_TX_INLINE_THRESHOLD=8192