Update for token handling in uccl_ep#828
Draft
shangguanshiyuan wants to merge 6 commits intouccl-project:mainfrom
Draft
Update for token handling in uccl_ep#828shangguanshiyuan wants to merge 6 commits intouccl-project:mainfrom
shangguanshiyuan wants to merge 6 commits intouccl-project:mainfrom
Conversation
Updated assertions to handle cases where pointers may be null when num_tokens is zero. Ensured that all necessary checks are in place for collective operations even when no tokens are present.
Member
|
Thanks for contribution! feel free to request review if the PR is ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated assertions to handle cases where pointers may be null when num_tokens is zero. Ensured that all necessary checks are in place for collective operations even when no tokens are present.
Description
Please include a summary of the changes and the related issue.
Fixes # (issue)
Type of Change
How Has This Been Tested?
Include any tests here.
Checklist
format.shto follow the style guidelines.build.shto verify compilation.