fix(filters): keep facet options that appear after a filter change - #402
Open
grzelaka-roche wants to merge 2 commits into
Open
grzelaka-roche wants to merge 2 commits into
grzelaka-roche wants to merge 2 commits into
Conversation
updateCountsInInitialTabsOptions built its output by walking only the frozen initialTabsOptions baseline. When the explorer mounts with a default filter applied, that baseline is captured from an already-filtered aggregation, so bucket keys that surface after an interactive filter change (present in the current response but absent from the baseline) were silently dropped from the UI and could not be displayed or selected. Build the option universe as the union of the current (processed) response and the frozen baseline: emit all current options first, then re-add baseline-only keys at count 0 to preserve the option-stability feature. The range-filter branch and selectedValues re-add block are unchanged. Co-authored-by: Codex <noreply@openai.com> Co-authored-by: Ona <no-reply@ona.com>
|
pushed update branch to test out image build push changes are happy. |
grzelaka-roche
marked this pull request as ready for review
September 17, 2026 09:48
Author
|
I added This is now ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUG - If guppy/explorer starts with some initial filters and then we drop those filters - the values that didn't exist before in other facets never get displayed.
To reproduce:
explorerStoreFilterInURLoption and some filter in the URL.updateCountsInInitialTabsOptions built its output by walking only the frozen initialTabsOptions baseline. When the explorer mounts with a default filter applied, that baseline is captured from an already-filtered aggregation, so bucket keys that surface after an interactive filter change (present in the current response but absent from the baseline) were silently dropped from the UI and could not be displayed or selected.
Build the option universe as the union of the current (processed) response and the frozen baseline: emit all current options first, then re-add baseline-only keys at count 0 to preserve the option-stability feature. The range-filter branch and selectedValues re-add block are unchanged.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
updateCountsInInitialTabsOptionsnow builds the option list as the union of the current aggregation response and the frozen baseline, instead of restricting output to baseline keys. Note: full end-to-end display also requires the companiongen3-ui-componentfixImprovements
Dependency updates
Deployment changes