[Bug]Fixed ladle ubook scrolling issue + bump node version#5395
Merged
[Bug]Fixed ladle ubook scrolling issue + bump node version#5395
Conversation
Deploying baseweb with
|
| Latest commit: |
17b9cb6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ab40005.baseweb.pages.dev |
| Branch Preview URL: | https://ubook-scroll-fix.baseweb.pages.dev |
DianaSuvorova
approved these changes
Apr 7, 2026
hualf1995
force-pushed
the
ubook-scroll-fix
branch
from
d0be939 to
17b9cb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1.Fix the ubook nav bar not scrolling bug. Fyi: https://github.com/tajo/ladle/releases/tag/%40ladle%2Freact%404.1.2
2. bump the node version in this change because
@ladle/reactrequires node>=20.0.0 (and node 24 matches the version which uber internal repo uses)Screen.Recording.2026-04-06.at.6.26.10.PM.mov
Scope
Major: Breaking change - since I bump the node version which can be a breaking change.