Enable HandleWildcardGenerics flag when building NullAway

[msridhar]

Wildcard generics checking is still too buggy to recommend to all, but we should run it on NullAway code to catch more issues with it.

Also remove AcknowledgeRestrictiveAnnotations as that is redundant with JSpecify mode.

[msridhar]

This change is part of the following stack:

• Enable HandleWildcardGenerics flag when building NullAway #1586 ◀

_{Change managed by git-spice.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.19%. Comparing base (31b14ce) to head (f2e7f8d).

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1586   +/-   ##
=========================================
  Coverage     88.19%   88.19%           
  Complexity     2947     2947           
=========================================
  Files           104      104           
  Lines          9842     9842           
  Branches       1982     1982           
=========================================
  Hits           8680     8680           
  Misses          560      560           
  Partials        602      602           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Walkthrough

This pull request modifies the buildWithNullAway Error Prone/NullAway configuration in the Gradle build file. The NullAway:AcknowledgeRestrictiveAnnotations option was removed from the checker options block, and a new NullAway:HandleWildcardGenerics option was added. The existing NullAway:CheckContracts and NullAway:JSpecifyMode options remain in place with adjusted formatting and ordering.

Possibly related PRs

• uber/NullAway#1548: Adds wildcard generic containment checking logic that directly depends on the NullAway:HandleWildcardGenerics configuration being enabled.
• uber/NullAway#1549: Implements constraint solver wildcard generic inference that is gated by the NullAway:HandleWildcardGenerics option being enabled in this configuration change.
• uber/NullAway#1330: Also modifies the buildWithNullAway Error Prone/NullAway options in the same Gradle configuration file, changing the NullAway option set within the same task.

Suggested reviewers

• yuxincs

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: enabling the HandleWildcardGenerics flag in the NullAway build configuration, which matches the actual modification in the buildWithNullAway task.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch enable-wildcard-checking-when-building-nullaway

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}