Enable generic bytecode tests on JDK 17#1561
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughRemoved Java-version conditional skips from multiple jspecify-related tests by deleting Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: Turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. 👉 Get your free trial and get 200 agent minutes per Slack user (a $50 value). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1561 +/- ##
=========================================
Coverage 88.45% 88.45%
Complexity 2878 2878
=========================================
Files 103 103
Lines 9603 9603
Branches 1935 1935
=========================================
Hits 8494 8494
Misses 532 532
Partials 577 577 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
95e38b5 to
72cee30
Compare
72cee30 to
d9a2727
Compare
These tests work on JDK 17 with the
-XDaddTypeAnnotationsToSymbol=trueflag, after the JDK 17.0.19 release, due to backported support. We have to modify our CI config a bit to install the right version of JDK 17 across platforms.Summary by CodeRabbit
Tests
Chores