Enable test for issue 1500 and add comment

[msridhar]

Fixes #1500

NullAway behaves correctly for this case. Test-only change.

Summary by CodeRabbit

Tests

• Re-enabled previously skipped test for wildcard type handling in generic declarations. Expanded test coverage with additional scenarios to validate null-safety analysis behavior across different generic type parameter patterns.

[msridhar]

This change is part of the following stack:

• Run inference for generic method calls nested inside receivers #1571
  • Improve handling of var-declared local variables #1573
    • Compensate for more annotations inserted by javac #1574
      • Enable test for issue 1500 and add comment #1560 ◀
        • Use ground target types when handling lambdas and method refs passed to generic methods #1575
          • More generic inference for diamond calls #1544
          • Fix for unbounded wildcard passed to @NullUnmarked type variable #1577
            • Detect and warn on annotations directly on wildcard types #1579

_{Change managed by git-spice.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.30%. Comparing base (1184b98) to head (5cbbfc3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1560   +/-   ##
=========================================
  Coverage     88.30%   88.30%           
  Complexity     2926     2926           
=========================================
  Files           104      104           
  Lines          9776     9776           
  Branches       1967     1967           
=========================================
  Hits           8633     8633           
  Misses          543      543           
  Partials        600      600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[msridhar]

Tinkering with this test revealed a deeper issue, unrelated to wildcards, that needs to be fixed separately. Will leave this in a draft state and then come back to it later.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9a35f390-8800-4a53-a2b9-f8ab210a300c

📥 Commits

Reviewing files that changed from the base of the PR and between 1184b98 and 5cbbfc3.

📒 Files selected for processing (1)

• nullaway/src/test/java/com/uber/nullaway/jspecify/WildcardTests.java

---

Walkthrough

This pull request re-enables the issue1500 test in WildcardTests that was previously ignored due to a tracked false positive with JSpecify wildcard inference. The test method annotation is updated to remove the @Ignore marker, and the embedded Java test source is expanded to include a non-wildcard factory method (Foo.ofNoWildcard) alongside the existing wildcard-based method, with additional test fields (FOO2 and FOO3) to demonstrate both the inference limitation case and the working alternative case.

Possibly related PRs

• uber/NullAway#1548: Updates wildcard subtyping and containment logic in CheckIdenticalNullabilityVisitor that aligns with the corrected behavior validated by the re-enabled issue1500 test.
• uber/NullAway#1549: Introduces wildcard generics inference changes that the updated issue1500 test directly exercises and validates.
• uber/NullAway#1558: Modifies GenericsChecks wildcard nullability logic and adds wildcard-capture test coverage related to the same inference behavior validated here.

Suggested reviewers

• lazaroclapp
• yuxincs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change—enabling a previously ignored test for issue 1500 and adding a comment to document the related work.
Linked Issues check	✅ Passed	The PR successfully addresses issue #1500 by enabling the test case and adding clarification via comments, directly meeting the objective to assert correct NullAway behavior for the reported JSpecify false positive with wildcard super types.
Out of Scope Changes check	✅ Passed	All changes are scoped to the test file (WildcardTests.java) and directly support the objective of addressing issue #1500; no production code modifications or unrelated changes are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-1500

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}