Skip to content

Modularize the annotations JAR#1537

Merged
msridhar merged 1 commit intouber:masterfrom
anthonyvdotbe:master
Apr 15, 2026
Merged

Modularize the annotations JAR#1537
msridhar merged 1 commit intouber:masterfrom
anthonyvdotbe:master

Conversation

@anthonyvdotbe
Copy link
Copy Markdown
Contributor

@anthonyvdotbe anthonyvdotbe commented Apr 15, 2026

Thank you for contributing to NullAway!

Please note that once you click "Create Pull Request" you will be asked to sign our Uber Contributor License Agreement via CLA assistant.

Before pressing the "Create Pull Request" button, please provide the following:

  • A description about what and why you are contributing, even if it's trivial.

  • The issue number(s) or PR number(s) in the description if you are contributing in response to those.

  • If applicable, unit tests.

Closes #1536. I'd like to use the annotations JAR as a Java module in a modularized application.

Summary by CodeRabbit

  • Chores
    • Enhanced module organization to improve library accessibility and compatibility with modular Java systems.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 15, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e6ad5160-7301-483c-bdf2-38f4c9467e6b

📥 Commits

Reviewing files that changed from the base of the PR and between 26a23ce and 39266ff.

📒 Files selected for processing (1)
  • annotations/src/main/java/module-info.java

Walkthrough

A Java module descriptor (module-info.java) was added to the annotations JAR at annotations/src/main/java/. The descriptor declares the module as com.uber.nullaway.annotations and exports the com.uber.nullaway.annotations package. This makes the annotations JAR a Java module compatible with the Java Platform Module System.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Modularize the annotations JAR' directly and concisely describes the main change: adding Java module support to the annotations JAR by introducing module-info.java.
Linked Issues check ✅ Passed The pull request fully implements the requirement from issue #1536 by adding the exact module-info.java file with the specified module declaration and package export.
Out of Scope Changes check ✅ Passed The pull request contains only the necessary module-info.java file addition for modularizing the annotations JAR, with no extraneous or unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not an expert on using modules but this LGTM

@msridhar msridhar enabled auto-merge (squash) April 15, 2026 19:19
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.48%. Comparing base (26a23ce) to head (39266ff).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1537   +/-   ##
=========================================
  Coverage     88.48%   88.48%           
  Complexity     2843     2843           
=========================================
  Files           103      103           
  Lines          9489     9489           
  Branches       1905     1905           
=========================================
  Hits           8396     8396           
  Misses          531      531           
  Partials        562      562           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msridhar msridhar merged commit 480c8d3 into uber:master Apr 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modularize the annotations JAR

3 participants