Add RunOnFailure option#129
Merged
sywhang merged 1 commit intouber-go:masterfrom Oct 1, 2024
Merged
Conversation
This adds an Option to run goleak when test runs fail. Fixes uber-go#128.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 99.14% 99.20% +0.06%
==========================================
Files 5 5
Lines 234 252 +18
==========================================
+ Hits 232 250 +18
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
abhinav
approved these changes
Oct 1, 2024
machine424
reviewed
Oct 1, 2024
| errorMsg string | ||
| ) | ||
|
|
||
| if !opts.runOnFailure && exitCode == 0 { |
There was a problem hiding this comment.
I don't think opts.runOnFailure should matter here.
to keep the old behaviour, we only need to check on exitCode.
if exitCode == 0 {
errorMsg = "goleak: Errors on successful test run:%v\n"
run = true
} else if opts.runOnFailure {
errorMsg = "goleak: Errors on unsuccessful test run: %v\n"
run = true
}
There was a problem hiding this comment.
I opened #132 in case this went unnoticed
machine424
added a commit
to machine424/uber-goleak
that referenced
this pull request
Oct 10, 2024
…ailure() option is used. adjust RunOnFailure() doc. follow up to uber-go#129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an Option to run goleak when test runs fail.
Fixes #128.