Repository navigation
Refresh alumni logo carousel, align Project Highlights, fix hidden navbar clicks - #435
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
✅ Deploy Preview for ubclaunchpad ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Swap the company logos for the current set (adds Apple, Bloomberg, Databricks, Datadog, Figma, Meta, OpenAI and Stripe; drops Asana, RBC, Shopify and Splunk) and render them from a data list as monochrome white marks on the page background instead of a white strip. The scroll is now a CSS keyframe animation with faded edges that respects prefers-reduced-motion, replacing the requestAnimationFrame loop that duplicated the container's innerHTML. The caption and logos share the about section's column so they line up with it.
Put the projects section in the same 1740px column as the section below so the title, cards and arrows share its left and right edges, and remove an unused InfoButton import.
The navbar only faded to opacity-0 when scrolling down, so it still sat on top of the page and caught clicks. Toggle visibility alongside opacity so it is removed from hit-testing and the tab order once the fade ends, and keep the last scroll position inside the effect.
bcw117
force-pushed
the
bcw117/update-company-carousel
branch
from
October 20, 2026 00:38
a104652 to
8191e46
Compare
bcw117
enabled auto-merge (squash)
October 20, 2026 00:42
bcw117
disabled auto-merge
October 20, 2026 00:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features and Changes
Refreshes the "Our Alumni" logo carousel on the landing page with the current set of companies and a design that fits the dark theme.
It also aligns the Project Highlights section with the section below it and fixes the hidden navbar still catching clicks.
Alumni logo carousel
tesla.svgis replaced with the emblem-plus-wordmark version.figma.svgis the official Figma wordmark from the logo pack on Figma's brand page, with its canvas cropped to the text.alumniCarousel.tsxrenders from acompanieslist instead of one hand-written block per logo.classNameper entry handles optical alignment; only Amazon uses it, shifting down 8px because the smile pulls its box center below the wordmark.brightness-0 invert opacity-85), so no SVG files need recoloring..logo-marquee-trackinglobals.css) that moves left to right over 40s.requestAnimationFrameloop that duplicated the container'sinnerHTML, so the component no longer needs"use client".aria-hiddenand its links are removed from the tab order.prefers-reduced-motion./images/...); most were relative before.Alumni section layout
Project Highlights
max-w-[1740px] px-8column as "Partner with us".p-4, so the visible card edges line up with the title.InfoButtonimport.Navbar
invisibleas well asopacity-0.transition-[opacity,visibility]keeps the 300ms fade in both directions.lastScrollTopmoved inside theuseEffectthat uses it, which clears thereact-hooks/exhaustive-depswarning.Screenshots / Screen Recordings
None attached yet.
The carousel, alumni section layout and Project Highlights alignment are all visual changes, so before/after screenshots of the landing page would help here.
Testing your changes
npx eslinton every changed source file: no errors or warnings.npx tsc --noEmit: no errors in the changed files.npx prettier --checkon the changed files: they pass, apart from pre-existing issues inglobals.css(see Other Notes).logo-marqueekeyframes,opacity-85and thetransition-[opacity,visibility]rule.prefers-reduced-motionweren't checked.pnpm buildwasn't run.Steps on how to test your changes
pnpm devand open/.Check that the logos scroll left to right, loop with no visible jump, fade at both edges and line up vertically.
Amazon in particular should line up with the others.
Nothing should navigate.
Scroll up and check that it fades back in and is clickable.
Other Notes
globals.cssalready had unformatted keyframes onmain(around line 357), and this PR leaves them as they are.If logos are added or removed, update it in
globals.cssto keep the speed; a comment there explains this.google.svghas a lot of built-in padding, so it gets a larger box than the other logos to look the same size.Cropping that SVG would be a cleaner fix.