Skip to content

Refresh alumni logo carousel, align Project Highlights, fix hidden navbar clicks - #435

Merged
bcw117 merged 3 commits into
mainfrom
bcw117/update-company-carousel
Oct 20, 2026
Merged

bcw117 merged 3 commits into
mainfrom
bcw117/update-company-carousel

Conversation

@bcw117

@bcw117 bcw117 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Features and Changes

Refreshes the "Our Alumni" logo carousel on the landing page with the current set of companies and a design that fits the dark theme.
It also aligns the Project Highlights section with the section below it and fixes the hidden navbar still catching clicks.

Alumni logo carousel

  • Logos are now Google, Microsoft, Apple, Amazon, Meta, OpenAI, Tesla, Bloomberg, Stripe, Datadog, Databricks and Figma.
  • Asana, RBC, Shopify and Splunk are removed, and tesla.svg is replaced with the emblem-plus-wordmark version.
  • figma.svg is the official Figma wordmark from the logo pack on Figma's brand page, with its canvas cropped to the text.
  • alumniCarousel.tsx renders from a companies list instead of one hand-written block per logo.
  • Each entry sets a display size that matches its SVG's aspect ratio and is tuned so wordmarks and icon-style logos have similar visual weight.
  • An optional className per entry handles optical alignment; only Amazon uses it, shifting down 8px because the smile pulls its box center below the wordmark.
  • The white strip and glow are gone.
  • Logos sit directly on the page background as monochrome white marks (brightness-0 invert opacity-85), so no SVG files need recoloring.
  • Scrolling is a CSS keyframe animation (.logo-marquee-track in globals.css) that moves left to right over 40s.
  • It replaces the requestAnimationFrame loop that duplicated the container's innerHTML, so the component no longer needs "use client".
  • The list is rendered twice for a seamless loop.
  • The duplicate copy is aria-hidden and its links are removed from the tab order.
  • Both edges fade out over 5% of the width with a CSS mask.
  • The animation is turned off under prefers-reduced-motion.
  • Image paths are now absolute (/images/...); most were relative before.

Alumni section layout

  • The caption and logo row now share the about section's 1340px column and insets.
  • They start at the team photo's left edge and end at the about text's right edge, instead of spanning the full screen.
  • The caption is left-aligned and reads "Developers, Designers, and more".
  • The section gets 128px of space above it, so the caption no longer peeks in at the bottom of the screen on first load.
  • The gap below it is reduced to 32px.

Project Highlights

  • The projects section uses the same max-w-[1740px] px-8 column as "Partner with us".
  • The title, the first card and the "Partner with us" title now share a left edge, and the arrows and last card share the right edge.
  • The card row is inset 16px less than the header because each slide has p-4, so the visible card edges line up with the title.
  • Removed an unused InfoButton import.

Navbar

  • When scrolling down, the navbar now toggles invisible as well as opacity-0.
  • Before this, it only faded out, so it still sat on top of the page and intercepted clicks.
  • transition-[opacity,visibility] keeps the 300ms fade in both directions.
  • lastScrollTop moved inside the useEffect that uses it, which clears the react-hooks/exhaustive-deps warning.

Screenshots / Screen Recordings

None attached yet.
The carousel, alumni section layout and Project Highlights alignment are all visual changes, so before/after screenshots of the landing page would help here.

Testing your changes

  • npx eslint on every changed source file: no errors or warnings.
  • npx tsc --noEmit: no errors in the changed files.
  • npx prettier --check on the changed files: they pass, apart from pre-existing issues in globals.css (see Other Notes).
  • Headless Chrome screenshots of the dev server at 1440px wide confirmed the following:
    • The logos render white and fade at both edges.
    • The caption and logo row start at the photo's left edge (122px) and end at the about text's right edge (1310px).
    • The Project Highlights title, first card and "Partner with us" title all start at 72px.
  • Logo sizing and alignment were compared in side-by-side renders of the SVGs at their display sizes.
  • The served CSS includes the new logo-marquee keyframes, opacity-85 and the transition-[opacity,visibility] rule.
  • Untested:
    • The scroll direction wasn't confirmed visually, because headless screenshots don't advance CSS animations reliably.
    • The navbar click-through fix wasn't tested by clicking.
    • Mobile and tablet widths and prefers-reduced-motion weren't checked.
    • pnpm build wasn't run.

Steps on how to test your changes

  1. Run pnpm dev and open /.
  2. Scroll to "Our Alumni have worked as...".
    Check that the logos scroll left to right, loop with no visible jump, fade at both edges and line up vertically.
    Amazon in particular should line up with the others.
  3. Check that the caption and logo row line up with the team photo's left edge and the about text's right edge.
  4. Scroll to Project Highlights and check that the title, cards and arrows line up with "Partner with us" below.
  5. Scroll down until the navbar fades out, then click where its links were.
    Nothing should navigate.
    Scroll up and check that it fades back in and is clickable.
  6. Optionally, turn on "Reduce motion" in your OS settings and check that the logo row stays still.
  7. Repeat the layout checks at tablet and phone widths.

Other Notes

  • The CI Prettier check will likely still comment on this PR.
    globals.css already had unformatted keyframes on main (around line 357), and this PR leaves them as they are.
  • The marquee duration is fixed at 40s, which is about 50px/s for the current logos.
    If logos are added or removed, update it in globals.css to keep the speed; a comment there explains this.
  • google.svg has a lot of built-in padding, so it gets a larger box than the other logos to look the same size.
    Cropping that SVG would be a cleaner fix.
  • Project cards are slightly narrower below 1740px wide because of the new side padding.

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
lp-website Ignored Ignored Oct 20, 2026 12:38am UTC

@netlify

netlify Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for ubclaunchpad ready!

Name Link
🔨 Latest commit 8191e46
🔍 Latest deploy log https://app.netlify.com/projects/ubclaunchpad/deploys/6ad6b80ac90776e8c97459c6
😎 Deploy Preview https://deploy-preview-435--ubclaunchpad.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Swap the company logos for the current set (adds Apple, Bloomberg,
Databricks, Datadog, Figma, Meta, OpenAI and Stripe; drops Asana, RBC,
Shopify and Splunk) and render them from a data list as monochrome
white marks on the page background instead of a white strip.

The scroll is now a CSS keyframe animation with faded edges that
respects prefers-reduced-motion, replacing the requestAnimationFrame
loop that duplicated the container's innerHTML. The caption and logos
share the about section's column so they line up with it.
Put the projects section in the same 1740px column as the section below
so the title, cards and arrows share its left and right edges, and
remove an unused InfoButton import.
The navbar only faded to opacity-0 when scrolling down, so it still
sat on top of the page and caught clicks. Toggle visibility alongside
opacity so it is removed from hit-testing and the tab order once the
fade ends, and keep the last scroll position inside the effect.
@bcw117
bcw117 force-pushed the bcw117/update-company-carousel branch from a104652 to 8191e46 Compare October 20, 2026 00:38
@bcw117
bcw117 enabled auto-merge (squash) October 20, 2026 00:42
@bcw117
bcw117 disabled auto-merge October 20, 2026 00:42
@bcw117
bcw117 merged commit f13f5b8 into main Oct 20, 2026
8 checks passed
@bcw117
bcw117 deleted the bcw117/update-company-carousel branch October 20, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant