Skip to content

Don't put JDK annotations in stub files; they belong in the annotated JDK#7655

Closed
mernst wants to merge 1 commit intotypetools:masterfrom
mernst:jdk-annotations-in-jdk
Closed

Don't put JDK annotations in stub files; they belong in the annotated JDK#7655
mernst wants to merge 1 commit intotypetools:masterfrom
mernst:jdk-annotations-in-jdk

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented Apr 22, 2026

Merge with typetools/jdk#267

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b02d17d2-f6e0-4103-a6ba-69ab5f778e76

📥 Commits

Reviewing files that changed from the base of the PR and between b768590 and 45190a1.

📒 Files selected for processing (1)
  • checker/src/main/java/org/checkerframework/checker/rlccalledmethods/jdk.astub
💤 Files with no reviewable changes (1)
  • checker/src/main/java/org/checkerframework/checker/rlccalledmethods/jdk.astub

📝 Walkthrough

Walkthrough

This pull request removes stub definitions for java.lang.AutoCloseable and java.io.Closeable from the Resource Leak Checker's Java Development Kit stub file. The deletion eliminates 19 lines of code that previously declared close methods with @SideEffectFree and @GuardSatisfied annotations for both interfaces. No replacement declarations are provided.

Possibly related PRs

Suggested labels

ResourceLeakChecker

Suggested reviewers

  • kelloggm
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mernst mernst closed this Apr 22, 2026
@mernst mernst deleted the jdk-annotations-in-jdk branch April 22, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant