Repository navigation
Conversation
| subprocess.run( | ||
| [sys.executable, "-m", "build", "--no-isolation"], | ||
| cwd=tmpdir, | ||
| [sys.executable, "-m", "build", "--no-isolation"], cwd=tmpdir, check=False |
There was a problem hiding this comment.
shouldn't this be check=True?
There was a problem hiding this comment.
Possibly, I just wanted to preserve current behavior in this PR. I'll explore this later and send a followup PR if it makes sense.
| capture_output=True, | ||
| text=True, | ||
| cwd=self.typeshed_path, | ||
| check=True, |
There was a problem hiding this comment.
you also added check=True here which I don't think preserves existing behavior?
There was a problem hiding this comment.
Oops, fixed. I will revisit all checks later.
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
I'm fine with landing this now and following up later.
|
how were these surfaced, out of curiosity? Should we run the linter as part of pre-commit? (Definitely not a blocker for this to land, just curious!) |
|
Ruff warnings (squiggly lines) while editing in VSCode. Yes, a linter would probably a good idea. I'm also fine with replacing black with ruff here (considering we don't need the control over stub formatting like we need in typeshed). |
No description provided.