refactor: replace walk with recursive fs.readdir#956
Open
slagiewka wants to merge 2 commits intotwigjs:masterfrom
Open
refactor: replace walk with recursive fs.readdir#956slagiewka wants to merge 2 commits intotwigjs:masterfrom
slagiewka wants to merge 2 commits intotwigjs:masterfrom
Conversation
minimatch v9 uses only the named export, no defaults. Adds a test suite to verify the compile module works.
`readdir` with `recursive` is possible since node v20.1.0/v18.17.0. This project already requires node v22, therefore this option can be safely used. The original project suggests to use `@root/walk` which also uses `readdir` but with manual recursion. The new lib was written ~3 years before stdlib had it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch has a commit from #955. It's required to 1) make it work 2) prove the change retains original functionality.
readdirwithrecursiveis possible since node v20.1.0/v18.17.0.This project already requires node v22, therefore this option can be
safely used.
The original project suggests to use
@root/walkwhich also usesreaddirbut with manual recursion. The new lib was written ~3 yearsbefore stdlib had it.