Provide PHP style output of booleans by specifying option.#913
Open
antoineveldhoven wants to merge 2 commits intotwigjs:masterfrom
Open
Provide PHP style output of booleans by specifying option.#913antoineveldhoven wants to merge 2 commits intotwigjs:masterfrom
antoineveldhoven wants to merge 2 commits intotwigjs:masterfrom
Conversation
Collaborator
|
I don't see any issue with this since the option is disabled by default. It gives an upgrade path for the next major version to change the default. May be a good idea to include a deprecation notice when the option is not enabled and a boolean is encountered? |
antoineveldhoven
force-pushed
the
php-style-booleans
branch
from
1942f4f to
d0fe646
Compare
…olean is encountered. Co-Authored-By: Will Rowe <[email protected]>
antoineveldhoven
force-pushed
the
php-style-booleans
branch
from
d0fe646 to
5220b0e
Compare
willrowe
approved these changes
Feb 3, 2026
Collaborator
|
@RobLoach if this looks good to you then go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the way to go, since this is a very old issue.
Please share your thoughts @willrowe && @RobLoach about this fix.
Aiming to fix #88
Since this change breaks every boolean test and / or comparison, I've introduced an option in order to enable PHP style boolean outputs.