Support variables in slice filter shorthand#881
Merged
willrowe merged 3 commits intotwigjs:masterfrom Nov 16, 2023
Merged
Conversation
RobLoach
changed the title
RobLoach
approved these changes
Nov 6, 2023
Collaborator
RobLoach
left a comment
RobLoach
left a comment
There was a problem hiding this comment.
Oh this is nice. Thanks a lot. Looks good to me. Anything else we should address before merging?
Contributor
Author
willrowe
requested changes
Nov 7, 2023
Contributor
Author
|
@willrowe Thanks for the extensive review; I will add the requested tests as soon as possible. |
antoineveldhoven
force-pushed
the
slice-filter-variables
branch
from
2aca8fd to
251e52b
Compare
Contributor
Author
|
@willrowe Can you take a look at my revision of this PR? |
willrowe
approved these changes
Nov 16, 2023
|
Nice, thank you for addressing this! |
Collaborator
|
@RobLoach can you go ahead and release v1.17.0? Everything in the milestone has been completed, so we might as well release instead of adding more at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #769