Add entities/dreps/v0 namespace#289
Merged
Merged
Conversation
3278039 to
f92cfcf
Compare
f92cfcf to
d00e485
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the new Cardano ledger state namespace entities/dreps/v0 to the scls-cardano package by introducing its CDDL definition and wiring it into the known-namespace registry, conformance tests, and reference CDDL loading list.
Changes:
- Add a new CDDL namespace module
Cardano.SCLS.Namespace.EntitiesDRepsdefining therecord_entryschema. - Register
entities/dreps/v0inCardano.SCLS.CDDL(KnownSpec instance, knownNamespaces list, andNamespaceKeySize). - Extend conformance and reference test infrastructure to include
entities/dreps/v0.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scls-cardano/testlib/Cardano/SCLS/Testlib.hs | Adds entities/dreps/v0 to the set of namespaces exercised by the testlib conformance properties. |
| scls-cardano/test/Reference.hs | Adds entities/dreps/v0 to the list of reference CDDL files expected from the CIP-0165 reference set. |
| scls-cardano/scls-cardano.cabal | Includes the new namespace module in the library build. |
| scls-cardano/cddl-src/Cardano/SCLS/Namespace/EntitiesDReps.hs | Introduces the CDDL rules for the entities/dreps/v0 namespace record_entry. |
| scls-cardano/cddl-src/Cardano/SCLS/CDDL.hs | Registers the new namespace spec, symbol, and key size in the central CDDL registry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cc86dba to
c41a6c7
Compare
c41a6c7 to
bccc8d8
Compare
qnikst
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.