Skip to content

Add entities/dreps/v0 namespace#289

Merged
joaosreis merged 2 commits into
mainfrom
joaosreis/entities-dreps
May 8, 2026
Merged

Add entities/dreps/v0 namespace#289
joaosreis merged 2 commits into
mainfrom
joaosreis/entities-dreps

Conversation

@joaosreis
Copy link
Copy Markdown
Member

No description provided.

@joaosreis joaosreis self-assigned this Apr 2, 2026
@joaosreis joaosreis changed the title Add entities/dreps/v0amespace definitions Add entities/dreps/v0 namespace Apr 2, 2026
@joaosreis joaosreis force-pushed the joaosreis/entities-dreps branch from 3278039 to f92cfcf Compare April 16, 2026 09:13
@joaosreis joaosreis force-pushed the joaosreis/entities-dreps branch from f92cfcf to d00e485 Compare May 7, 2026 08:40
@joaosreis joaosreis marked this pull request as ready for review May 7, 2026 08:40
Copilot AI review requested due to automatic review settings May 7, 2026 08:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the new Cardano ledger state namespace entities/dreps/v0 to the scls-cardano package by introducing its CDDL definition and wiring it into the known-namespace registry, conformance tests, and reference CDDL loading list.

Changes:

  • Add a new CDDL namespace module Cardano.SCLS.Namespace.EntitiesDReps defining the record_entry schema.
  • Register entities/dreps/v0 in Cardano.SCLS.CDDL (KnownSpec instance, knownNamespaces list, and NamespaceKeySize).
  • Extend conformance and reference test infrastructure to include entities/dreps/v0.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scls-cardano/testlib/Cardano/SCLS/Testlib.hs Adds entities/dreps/v0 to the set of namespaces exercised by the testlib conformance properties.
scls-cardano/test/Reference.hs Adds entities/dreps/v0 to the list of reference CDDL files expected from the CIP-0165 reference set.
scls-cardano/scls-cardano.cabal Includes the new namespace module in the library build.
scls-cardano/cddl-src/Cardano/SCLS/Namespace/EntitiesDReps.hs Introduces the CDDL rules for the entities/dreps/v0 namespace record_entry.
scls-cardano/cddl-src/Cardano/SCLS/CDDL.hs Registers the new namespace spec, symbol, and key size in the central CDDL registry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@joaosreis joaosreis force-pushed the joaosreis/entities-dreps branch 2 times, most recently from cc86dba to c41a6c7 Compare May 7, 2026 13:21
@joaosreis joaosreis requested a review from qnikst May 7, 2026 13:22
@joaosreis joaosreis force-pushed the joaosreis/entities-dreps branch from c41a6c7 to bccc8d8 Compare May 7, 2026 13:23
@joaosreis joaosreis merged commit 3ec837f into main May 8, 2026
26 checks passed
@joaosreis joaosreis deleted the joaosreis/entities-dreps branch May 8, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants