Skip to content

Introduce accounts/v0 namespace#256

Closed
qnikst wants to merge 2 commits intomainfrom
qn/accounts-ns
Closed

Introduce accounts/v0 namespace#256
qnikst wants to merge 2 commits intomainfrom
qn/accounts-ns

Conversation

@qnikst
Copy link
Copy Markdown
Member

@qnikst qnikst commented Mar 17, 2026

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for the new accounts/v0 SCLS namespace by introducing its CDDL schema, registering it as a known namespace, and updating reference/CIP wiring so conformance checks can include it.

Changes:

  • Add Cardano.SCLS.Namespace.Accounts CDDL schema and register accounts/v0 in Cardano.SCLS.CDDL (including key size).
  • Extend reference CDDL loading list to include accounts_v0.cddl.
  • Update Nix/CI pins to a CIPs revision/branch that contains the new accounts_v0.cddl.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scls-cardano/testlib/Cardano/SCLS/Testlib.hs Adds accounts/v0 to the “test all namespaces” constraint set.
scls-cardano/test/Reference.hs Includes accounts/v0 reference CDDL filename in allReferenceCDDLs.
scls-cardano/scls-cardano.cabal Adds the Accounts namespace module to the library build.
scls-cardano/cddl-src/Cardano/SCLS/Namespace/Accounts.hs Introduces the Accounts namespace CDDL rules (record entry + supporting types).
scls-cardano/cddl-src/Cardano/SCLS/Common.hs Adds word64_non_zero helper rule.
scls-cardano/cddl-src/Cardano/SCLS/CDDL.hs Registers accounts/v0 spec and namespace key size; adds to known namespaces.
flake.nix Switches CIPs input to the accounts ref.
flake.lock Updates pinned CIPs revision/hash accordingly.
.github/workflows/haskell-ci.yml Updates the checked-out CIPs commit used to provide reference CDDL.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scls-cardano/cddl-src/Cardano/SCLS/Common.hs
Comment thread scls-cardano/testlib/Cardano/SCLS/Testlib.hs
@qnikst qnikst changed the title Qn/accounts ns Introduce accounts/v0 namespace Mar 17, 2026
@qnikst
Copy link
Copy Markdown
Member Author

qnikst commented Mar 17, 2026

After trying to integrate with cardano-ledger I realised that I've used spec types for DState, so I have to update that to use real data.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>
@joaosreis
Copy link
Copy Markdown
Member

Done in #288

@joaosreis joaosreis closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants