Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for the new accounts/v0 SCLS namespace by introducing its CDDL schema, registering it as a known namespace, and updating reference/CIP wiring so conformance checks can include it.
Changes:
- Add
Cardano.SCLS.Namespace.AccountsCDDL schema and registeraccounts/v0inCardano.SCLS.CDDL(including key size). - Extend reference CDDL loading list to include
accounts_v0.cddl. - Update Nix/CI pins to a CIPs revision/branch that contains the new
accounts_v0.cddl.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scls-cardano/testlib/Cardano/SCLS/Testlib.hs | Adds accounts/v0 to the “test all namespaces” constraint set. |
| scls-cardano/test/Reference.hs | Includes accounts/v0 reference CDDL filename in allReferenceCDDLs. |
| scls-cardano/scls-cardano.cabal | Adds the Accounts namespace module to the library build. |
| scls-cardano/cddl-src/Cardano/SCLS/Namespace/Accounts.hs | Introduces the Accounts namespace CDDL rules (record entry + supporting types). |
| scls-cardano/cddl-src/Cardano/SCLS/Common.hs | Adds word64_non_zero helper rule. |
| scls-cardano/cddl-src/Cardano/SCLS/CDDL.hs | Registers accounts/v0 spec and namespace key size; adds to known namespaces. |
| flake.nix | Switches CIPs input to the accounts ref. |
| flake.lock | Updates pinned CIPs revision/hash accordingly. |
| .github/workflows/haskell-ci.yml | Updates the checked-out CIPs commit used to provide reference CDDL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
After trying to integrate with cardano-ledger I realised that I've used spec types for DState, so I have to update that to use real data. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
joaosreis
approved these changes
Mar 18, 2026
Member
|
Done in #288 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.