allow passing arguments down to source() from loadConfig()#98
Open
mshvartsman wants to merge 1 commit intotudo-r:masterfrom
Open
allow passing arguments down to source() from loadConfig()#98mshvartsman wants to merge 1 commit intotudo-r:masterfrom
mshvartsman wants to merge 1 commit intotudo-r:masterfrom
Conversation
…onfig to use relative paths for its .tmpl files, which is useful in being able to organize (bigger) codebases that rely on BatchJobs.
Author
|
I should add that personally, think a better solution is to default to
The pull request as it is now doesn't change the status quo: 1 and 3 still work, 2 still breaks (but can now be fixed by the user passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using BatchJobs in moderately sized codebases, it can be helpful to use relative paths for both .tmpl and config files.
loadConfig()usessys.source()(viasourceConfFile()), which by default sources the config file relative to the current path, not the path of the config file itself. There are a number of ways to address this -- I think I picked the least disruptive (but maybe most awkward), which is passing arguments fromloadConfig()down tosys.source(), and passingchdir=Tto evaluate paths in the config file relative to its own directory.