Added a cache for responses to fonts#336
Open
Nikitozz13 wants to merge 2 commits intotsayen:masterfrom
Open
Conversation
Nikitozz13
changed the title
additv
pushed a commit
to additv/dom-to-image
that referenced
this pull request
Jun 18, 2020
InYourHead
pushed a commit
to InYourHead/dom-to-image
that referenced
this pull request
Sep 17, 2020
InYourHead
pushed a commit
to InYourHead/dom-to-image
that referenced
this pull request
Sep 17, 2020
|
I merged this PR to my repository and I can confirm that this fix speed up whole operation. |
IDisposable
added a commit
to 1904labs/dom-to-image-more
that referenced
this pull request
Sep 7, 2022
This eliminates the constant redownloading of referenced fonts images and such. The cache is cleared after the completion of the toSvg method and is based on the requested URL, not the cache-busted URL. Based on the work in tsayen#336 and resolves #79
|
This is released in dom-to-image-more 1.12.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of many duplicated fonts downloading need to add a cache for them to prevent that.
This PR based on @kumarsai solution.
On my project it reduced all the responses in several times! So it download the font only once and reuse the response for the further requests to the same font.
Issue: #37