feat: record VERP envelope senders in forensic report archive copies - #435
Merged
thegushi merged 1 commit intoJun 22, 2026
Conversation
VERP only changes the SMTP envelope (MAIL FROM); it leaves no trace in the message itself, so an archived copy (--archive-dir) of a forensic report gave no way to confirm whether, or how, VERP fired for a given send -- not even by comparing against what the recipient's own server might stamp as Return-Path, since that's only ever visible to them. Archived forensic-report copies are now prefixed with a few "#" comment lines recording the envelope sender(s) actually used: the full recipient -> VERP-address mapping when --verp is on, or the plain --report-email address otherwise. This is deliberately not styled as RFC822 headers, since archive_report()'s purpose is to capture the message exactly as handed to SMTP, and inventing header lines that were never really part of it would misrepresent that more than a non-standard comment preamble does. The message actually transmitted over SMTP is unchanged.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--verponly changes the SMTP envelope (MAIL FROM); it leaves no trace in the message itself, so an archived copy (--archive-dir) of a forensic report gave no way to confirm whether, or how, VERP fired for a given send.#comment lines recording the envelope sender(s) actually used: the full recipient -> VERP-address mapping when--verpis on, or the plain--report-emailaddress otherwise.archive_report()'s purpose is to capture the message exactly as handed to SMTP, and inventing header lines that were never really part of it would misrepresent that more than a non-standard comment preamble does.Test plan
perl -csyntax check on the regeneratedopendmarc-reports--verpis on, and the single static address when it's off