libopendkim: declare dkim_error and dkim_get_key in dkim-internal.h (fixes #413) - #432
Merged
thegushi merged 1 commit intoJul 23, 2026
Conversation
…ixes trusteddomainproject#413) Both functions were only reachable via matching file-local extern declarations copied into five (dkim_error) and one (dkim_get_key) source files. Centralize them in dkim-internal.h, which all of those files already include, and drop the redundant copies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dkim_error()is defined inlibopendkim/dkim.cbut was declared via a matching file-localexterncopied intodkim-report.c,dkim-keys.c,dkim-canon.c,dkim-util.c, anddkim-atps.cinstead of a shared header.dkim_get_key()had the same problem, with its own localexternindkim-test.c.libopendkim/dkim-internal.h(already included by all affected files) and removes the six redundant local declarations.Fixes #413.
Test plan
autoreconf -fi && ./configure && gmakeinlibopendkim/with no new errors or warnings.