opendkim/tests/Makefile.am: add miltertest and opendkim as check deps - #419
Merged
thegushi merged 1 commit intoJun 16, 2026
Merged
Conversation
Abuse the check_DATA variable to indicate that the "miltertest" and "opendkim" programs are dependencies of every test in this directory. Afterwards, add rules to build them. This ensures that "make check" can be run before "make".
Collaborator
|
Merging, but note that for other libraries (like OpenDMARC) I'm forking miltertest off to its own repo, so it may make sense for any upstream packagers to use that. (I'd like it to get its own level of CI/makefile love. Basically, any milter that wants to use miltertest can just pull that in, without having to pull in OpenDKIM. |
Author
|
No problem, I'll keep an eye out and package miltertest separately once it's split. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abuse the
check_DATAvariable to indicate that the miltertest and opendkim programs are dependencies of every test in this directory. Afterwards, add rules to build them. This ensures thatmake checkcan be run beforemake.