Skip to content

Make viscosity inplace and avoid duplicate velocity loads #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svchb merged 17 commits into from
Apr 13, 2026

Merge branch 'main' into inplace-viscosity

d58afa4
Select commit
Loading
Failed to load commit list.
Merged

Make viscosity inplace and avoid duplicate velocity loads #1125

Merge branch 'main' into inplace-viscosity
d58afa4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 13, 2026 in 1s

67.03% (-0.01%) compared to ca35699, passed because coverage increased by 0.01% when compared to adjusted base (67.02%)

View this Pull Request on Codecov

67.03% (-0.01%) compared to ca35699, passed because coverage increased by 0.01% when compared to adjusted base (67.02%)

Details

Codecov Report

❌ Patch coverage is 68.08511% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.03%. Comparing base (ca35699) to head (d58afa4).

Files with missing lines Patch % Lines
...chemes/structure/total_lagrangian_sph/viscosity.jl 12.00% 22 Missing ⚠️
src/schemes/fluid/viscosity.jl 90.54% 7 Missing ⚠️
src/schemes/boundary/open_boundary/rhs.jl 0.00% 5 Missing ⚠️
...chemes/fluid/implicit_incompressible_sph/system.jl 0.00% 5 Missing ⚠️
src/schemes/boundary/wall_boundary/system.jl 60.00% 2 Missing ⚠️
src/schemes/structure/rigid_body/system.jl 0.00% 2 Missing ⚠️
...c/schemes/structure/total_lagrangian_sph/system.jl 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
- Coverage   67.03%   67.03%   -0.01%     
==========================================
  Files         128      128              
  Lines        9808     9844      +36     
==========================================
+ Hits         6575     6599      +24     
- Misses       3233     3245      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov