Skip to content

Small fixes to callbacks #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
efaulhaber wants to merge 7 commits into
base: main
Choose a base branch
from
+19 −3

Add interpolation fix

72cf15e
Select commit
Loading
Failed to load commit list.
Open

Small fixes to callbacks #1101

Add interpolation fix
72cf15e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 17, 2026 in 1s

67.25% (-22.27%) compared to 2d42821

View this Pull Request on Codecov

67.25% (-22.27%) compared to 2d42821

Details

Codecov Report

❌ Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.25%. Comparing base (2d42821) to head (72cf15e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/callbacks/steady_state_reached.jl 0.00% 5 Missing ⚠️
...rc/schemes/fluid/weakly_compressible_sph/system.jl 0.00% 5 Missing ⚠️
src/callbacks/density_reinit.jl 0.00% 1 Missing ⚠️
src/general/initial_condition.jl 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2d42821) and HEAD (72cf15e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (2d42821) HEAD (72cf15e)
total 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1101       +/-   ##
===========================================
- Coverage   89.51%   67.25%   -22.27%     
===========================================
  Files         126      126               
  Lines        9614     9601       -13     
===========================================
- Hits         8606     6457     -2149     
- Misses       1008     3144     +2136

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov