Make stage_limiter! a kwarg

[JoshuaLampert]

Split out of #2910.

[github-actions]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• The PR has a single goal that is clear from the PR title and/or description.
• All code changes represent a single set of modifications that logically belong together.
• No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• The code can be understood easily.
• Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• There are no redundancies that can be removed by simple modularization/refactoring.
• There are no leftover debug statements or commented code sections.
• The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• New functions and types are documented with a docstring or top-level comment.
• Relevant publications are referenced in docstrings (see example for formatting).
• Inline comments are used to document longer or unusual code sections.
• Comments describe intent ("why?") and not just functionality ("what?").
• If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

• The PR passes all tests.
• New or modified lines of code are covered by tests.
• New or modified tests run in less then 10 seconds.

Performance

• There are no type instabilities or memory allocations in performance-critical parts.
• If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• The correctness of the code was verified using appropriate tests.
• If new equations/methods are added, a convergence test has been run and the results
  are posted in the PR.

Created with ❤️ by the Trixi.jl community.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (c8a0f2d) to head (5e882f8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2995   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         625      625           
  Lines       48514    48514           
=======================================
  Hits        47122    47122           
  Misses       1392     1392           

Flag	Coverage Δ
unittests	97.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[JoshuaLampert]

Looks like macOS MPI is stuck, @vchuravy...
Edit: After restarting it runs through again.

[vchuravy]

Looks like macOS MPI is stuck

For some reason we got:, during the run.

elixir_advection_restart.jl: Test Failed at /Users/runner/.julia/packages/TrixiTest/6CVoC/src/macros.jl:220
  Expression: #= /Users/runner/.julia/packages/TrixiTest/6CVoC/src/macros.jl:220 =# @allocated(($(Expr(:escape, :(Trixi.rhs!))))(du, u, $(Expr(:escape, :semi)), t)) < $(Expr(:escape, 1000))
   Evaluated: 92000 < 1000

I suspect that generally the MPI test may hang since we don't see what the other ranks are up to. So rank 0 is encountering an issue, that may lead to a divergence since the other ranks are executing a different code path. Very hard to figure out.

[ranocha]

Thanks!